fix(auth): prevent exchange rate expired due to missing user flags#660
Merged
Merged
Conversation
bmc08gt
commented
May 2, 2026
bmc08gt
commented
Collaborator
- Move Events.OnLoggedIn from set(flags) to set(authState) with transition guard so it fires exactly once per session
- Retry getUserFlags() with retryable(maxRetries=3) on login
- Relax updateUserFlags() guard to isAtLeastRegistered and promote auth state on successful recovery
- Observe network restoration to retry flags fetch when stuck in Registered state
- Add real time-based expiration to exchangeDataFor() with 15m default fallback instead of returning null when timeout is unset
- Move Events.OnLoggedIn from set(flags) to set(authState) with transition guard so it fires exactly once per session - Retry getUserFlags() with retryable(maxRetries=3) on login - Relax updateUserFlags() guard to isAtLeastRegistered and promote auth state on successful recovery - Observe network restoration to retry flags fetch when stuck in Registered state - Add real time-based expiration to exchangeDataFor() with 15m default fallback instead of returning null when timeout is unset Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
force-pushed
the
fix/exchange-rate-expired-missing-flags
branch
from
b469f54 to
e366322
Compare
bmc08gt
added
type: fix
bmc08gt
added a commit
that referenced
this pull request
Jul 8, 2026
… grab span refactor Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
added a commit
that referenced
this pull request
Jul 8, 2026
Wrap the grab (poll give-request, token metadata, account creation, request-grab) and give (resolve exchange data, send request, await grab, submit intent, poll metadata) stages in spans on the shared PaymentTrace, keyed by the rendezvous public key. Restores the PR #660 account-recovery rationale comment folded in during the grab-span refactor. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.