fix(compose): fix stale lambda captures and effect key issues#836
Merged
Conversation
bmc08gt
commented
Jun 3, 2026
bmc08gt
commented
Collaborator
- Fix stale onStateChanged lambda in TextInput by using rememberUpdatedState, preventing stale closure in LaunchedEffect(Unit)
- Fix stale onDelete lambda in SwipeToRevealItem by using rememberUpdatedState for the captured callback
- Replace LaunchedEffect(swipeFraction) in SlideToConfirm with snapshotFlow-based collection to avoid cancelling/restarting the effect on every drag frame
- Key permission screen LaunchedEffects on permissionState.status instead of Unit so navigation fires when status settles async
- Fix stale onStateChanged lambda in TextInput by using rememberUpdatedState, preventing stale closure in LaunchedEffect(Unit) - Fix stale onDelete lambda in SwipeToRevealItem by using rememberUpdatedState for the captured callback - Replace LaunchedEffect(swipeFraction) in SlideToConfirm with snapshotFlow-based collection to avoid cancelling/restarting the effect on every drag frame - Key permission screen LaunchedEffects on permissionState.status instead of Unit so navigation fires when status settles async
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.