Skip to content

fix(compose): defer animation reads to draw/layout phase #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 4, 2026
Merged

fix(compose): defer animation reads to draw/layout phase #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...stomization/src/main/kotlin/com/flipcash/app/bill/customization/components/HueScroller.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import androidx.compose.ui.draw.clip
import androidx.compose.ui.draw.drawBehind
import androidx.compose.ui.draw.drawWithCache
import androidx.compose.ui.draw.drawWithContent
import androidx.compose.ui.draw.scale
import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.geometry.CornerRadius
import androidx.compose.ui.geometry.Offset
import androidx.compose.ui.geometry.Size
Expand Down Expand Up @@ -108,7 +108,10 @@ internal fun HueScroller(
modifier = Modifier
.align(Alignment.Center)
.width(thumbWidth)
.scale(scale),
.graphicsLayer {
scaleX = scale
scaleY = scale
},
hsv = currentHsv,
)
}
Expand Down
7 changes: 5 additions & 2 deletions ...rc/main/kotlin/com/flipcash/app/bill/customization/components/SaturationBrightnessGrid.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.draw.drawBehind
import androidx.compose.ui.draw.scale
import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.geometry.CornerRadius
import androidx.compose.ui.geometry.Offset
import androidx.compose.ui.graphics.BlendMode
Expand Down Expand Up @@ -173,7 +173,10 @@ private fun BoxScope.Thumb(
)
}
.size(thumbSize)
.scale(scale)
.graphicsLayer {
scaleX = scale
scaleY = scale
}
.align(Alignment.TopStart)
) {
Box(
Expand Down
7 changes: 6 additions & 1 deletion ui/components/src/main/kotlin/com/getcode/ui/components/Flippable.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import androidx.compose.foundation.layout.BoxScope
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.runtime.Composable
import androidx.compose.runtime.State
import androidx.compose.runtime.derivedStateOf
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.graphicsLayer

Expand Down Expand Up @@ -59,6 +62,8 @@ fun FlippableCard(
}
}

val showFront by remember { derivedStateOf { rotation.value <= 90f } }

Box(
modifier = modifier
.graphicsLayer {
Expand All @@ -67,7 +72,7 @@ fun FlippableCard(
}
) {
if (cardFace != CardFace.Neither) {
if (rotation.value <= 90f) {
if (showFront) {
Box(
modifier = Modifier
.fillMaxSize()
Expand Down
14 changes: 8 additions & 6 deletions ui/components/src/main/kotlin/com/getcode/ui/components/chat/TypingIndicator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.draw.scale
import androidx.compose.ui.draw.drawBehind
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.ColorFilter
import androidx.compose.ui.graphics.CompositingStrategy
Expand Down Expand Up @@ -191,11 +191,13 @@ private fun TypingDots(
Box(
modifier = Modifier
.size(CodeTheme.dimens.grid.x2)
.scale(scale.value)
.background(
color = baseColor.copy(alpha = alpha.value),
shape = CircleShape
)
.graphicsLayer {
scaleX = scale.value
scaleY = scale.value
}
.drawBehind {
drawCircle(color = baseColor.copy(alpha = alpha.value))
}
)
}
}
Expand Down
Loading