Skip to content

fix(compose): replace SharingStarted.Eagerly with WhileSubscribed in ViewModels #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 4, 2026
Merged

fix(compose): replace SharingStarted.Eagerly with WhileSubscribed in ViewModels #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/flipcash/app/src/main/kotlin/com/flipcash/app/internal/ui/HomeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ internal class HomeViewModel @Inject constructor(
private val _requireBiometrics = MutableStateFlow<Boolean?>(null)
val requireBiometrics = _requireBiometrics.stateIn(
viewModelScope,
started = SharingStarted.Eagerly,
started = SharingStarted.WhileSubscribed(5_000),
initialValue = null
)

Expand Down
12 changes: 1 addition & 11 deletions ...lipcash/features/lab/src/main/kotlin/com/flipcash/app/lab/internal/LabsScreenViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,17 @@ package com.flipcash.app.lab.internal
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.flipcash.app.userflags.UserFlagsCoordinator
import com.flipcash.services.user.AuthState
import com.flipcash.services.user.UserManager
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.filterIsInstance
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.stateIn
import javax.inject.Inject

@HiltViewModel
class LabsScreenViewModel @Inject constructor(
userManager: UserManager,
userFlags: UserFlagsCoordinator,
) : ViewModel() {

val isLoggedIn = userManager
.state.map { it.authState }
.filterIsInstance<AuthState.Ready>()
.map { true }
.stateIn(viewModelScope, started = SharingStarted.Eagerly, initialValue = false)

val isStaff = userFlags.resolvedFlags.map { it.isStaff.effectiveValue }
.stateIn(viewModelScope, started = SharingStarted.Eagerly, initialValue = false)
.stateIn(viewModelScope, started = SharingStarted.WhileSubscribed(5_000), initialValue = false)
}
Loading