fix: keep the max-buy gate test from performing a real buy#482
Open
raulriera wants to merge 1 commit into
Open
fix: keep the max-buy gate test from performing a real buy#482raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
The gate test seeded a fresh verified state and generous limits, so after clearing the gate it ran the real session.buy — submitting an IntentCreateAccount to production that the antispam guard denied, firing the Critical SubmitIntent Failure alert on every unit run. Seed a daily limit below the entered amount instead, so the flow stops at the limit check, and assert that exit point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max-buy gate test added in #470 seeds everything the buy flow needs, so after clearing the balance gate it performed a real buy — submitting an account-creation intent to production that the antispam guard denied. Every unit-test run fired two of these, which is what re-triggered the Critical SubmitIntent Failure alerts. The test now seeds a daily send limit below the entered amount, so the flow clears the gate and stops at the limit check, and a new assertion pins that exit point so any future path back to the network buy fails the test. #457 remains the structural backstop for test sessions reaching production at all.
Test plan: