Skip to content

Blob storage key should use the UUID string #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffyanta merged 1 commit into from
Jun 29, 2026
Merged

Blob storage key should use the UUID string #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions blob/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package blob

import (
"context"
"encoding/hex"
"errors"
"fmt"

Expand Down Expand Up @@ -62,7 +61,7 @@ type ObjectStorage interface {
// so an image's bytes live under a per-media-item directory keyed by its id,
// leaving room to group its renditions under the same prefix:
//
// images/<id-hex>/original.jpg
// images/<uuid>/original.jpg
//
// Only images are supported today, so a non-image mime type is rejected outright
// rather than being silently forced into the image layout. Other kinds (videos,
Expand All @@ -74,6 +73,9 @@ func StorageKey(id *blobpb.BlobId, mimeType string) (string, error) {
// Gate on the image kind explicitly, not merely on a resolvable extension: if
// mimeTypeToExtension later grows video/file entries, this still rejects them
// so they cannot inherit the image layout by accident.
if err := id.Validate(); err != nil {
return "", err
}
if !SupportedImageMimeTypes[mimeType] {
return "", fmt.Errorf("unsupported non-image mime type %q for storage key", mimeType)
}
Expand All @@ -82,5 +84,5 @@ func StorageKey(id *blobpb.BlobId, mimeType string) (string, error) {
// An image kind with no registered extension means the two image maps drifted.
return "", fmt.Errorf("missing extension for image mime type %q", mimeType)
}
return fmt.Sprintf("images/%s/original%s", hex.EncodeToString(id.Value), ext), nil
return fmt.Sprintf("images/%s/original%s", blobIDString(id), ext), nil
}
Loading