Skip to content

Media is optional in message sender for consumers that don't require it #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffyanta merged 1 commit into from
Jul 6, 2026
Merged

Media is optional in message sender for consumers that don't require it #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions messaging/sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,10 @@ func (s *Sender) Send(
// media-free sends; the message is already persisted, so a resolution failure
// just leaves Blob unset for clients to re-fetch.
msgProto := msg.ToProto()
if err := hydrateMedia(ctx, s.media, []*messagingpb.Message{msgProto}); err != nil {
log.With(zap.Error(err)).Warn("Failure resolving media metadata")
if s.media != nil {
if err := hydrateMedia(ctx, s.media, []*messagingpb.Message{msgProto}); err != nil {
log.With(zap.Error(err)).Warn("Failure resolving media metadata")
}
}

// A retried send (same client message ID) already ran every side effect when
Expand Down
Loading