Feature/user management - #8
Open
tomaszstefaniuk wants to merge 5 commits into
Open
Conversation
piotrmoszkowicz
suggested changes
May 10, 2022
| <PageLayout | ||
| py={5} | ||
| px={2} | ||
| mt={0} |
Contributor
There was a problem hiding this comment.
Is there a need to declare mt={0}. Shouldn't PageLayout have 0 ootb, so parent components are able to align it without problems?
Author
There was a problem hiding this comment.
I had to because <PageLayout /> has margin-top set to 32px by default. And I didn't wanted it in my case.
mksawic
reviewed
May 11, 2022
| color: rgbaColors.grey.main, | ||
| border: `1px solid ${rgbaColors.grey.lighter}`, | ||
| background: "none", | ||
| py: 1.125, |
There was a problem hiding this comment.
Why is it different Y-padding for disabled button? Text inside might flicker when button will change from active to disabled
Author
There was a problem hiding this comment.
The reason is that disabled button gets 1px border on top and bottom. And to stay with the same height as on not disabled button I need to subtract this extra 2px added from border by making smaller padding.
| }} | ||
| icon={false} | ||
| > | ||
| Something went wrong. Please try again. |
There was a problem hiding this comment.
text inside Alert shouldn't be hardcoded + it's looks like onClose calls 2 time (first in Snackbar props and second in Alert props)
Author
There was a problem hiding this comment.
The thing is that as the most external and main component of this popup needs it for example to close it when we click outside this element. And as different component I putted inside gives me ‘X’ icon only when I pass onClose prop which is also saying what it should do onClose.
Comment on lines
6
to
+17
| const IndexPage = lazy(() => import("./routes/Index/IndexPage")); | ||
| const SignIn = lazy(() => import("./routes/SignIn/SignIn")); | ||
| const SignUp = lazy(() => import("./routes/SignUp/SignUp")); | ||
| const VerifyEmail = lazy(() => import("./routes/VerifyEmail/VerifyEmail")); | ||
| const Users = lazy(() => import("./routes/UsersAdministration/Users/Users")); | ||
| const UserDetails = lazy(() => | ||
| import("./routes/UsersAdministration/Users/UserDetails/UserDetails") | ||
| ); | ||
| const Groups = lazy(() => import("./routes/UsersAdministration/Groups/Groups")); | ||
| const GroupDetails = lazy(() => | ||
| import("./routes/UsersAdministration/Groups/GroupDetails/GroupDetails") | ||
| ); |
There was a problem hiding this comment.
Can we make this alphabetical order?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create views for Users Administration.
Added:
-Users, Groups, User's Details and Group's details views based on routes.;
-Upgrade react-router-dom from 5.3.0 to 6.3.0.;
-Modals and error notification;
Need to be added:
FE:
-getting and handling data from backend, tests;
BE:
-search;
-returning data for tables;
-endpoints;