Skip to content

refactor: rename maps_url to url #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IronBlood merged 2 commits into from
Mar 11, 2026
Merged

refactor: rename maps_url to url #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e993d1c
refactor: rename maps_url to url
IronBlood Feb 6, 2026
7b53a65
fix: field
IronBlood Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ on:
pull_request:
paths:
- "data/events.yml"
- "events.schema.json"
push:
branches:
- main
paths:
- "data/events.yml"
- "events.schema.json"

permissions:
contents: read
Expand Down
8 changes: 4 additions & 4 deletions data/dummy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@
location: Garden Books, 325 Changle Road, Xuhui District, shanghai

- id: 9193c7ad-db78-4cd6-8d6c-8ce5daef61aa
title: test event with location and maps_url
title: test event with location and url
kind: test
start: 2026-02-04T17:00:00+08:00
end: 2026-02-04T18:00:00+08:00
location: Garden Books, 325 Changle Road, Xuhui District, shanghai
maps_url: https://www.openstreetmap.org/#map=18/31.221825/121.452855
url: https://www.openstreetmap.org/#map=18/31.221825/121.452855

- id: 9193c7ad-db78-4cd6-8d6c-8ce5daef2222
title: test event with location, maps_url and description
title: test event with location, url and description
kind: test
start: 2026-02-05T17:00:00+08:00
end: 2026-02-05T18:00:00+08:00
location: Garden Books, 325 Changle Road, Xuhui District, shanghai
maps_url: https://www.openstreetmap.org/#map=18/31.221825/121.452855
url: https://www.openstreetmap.org/node/4623058291
description: foo
2 changes: 1 addition & 1 deletion events.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"location": {
"type": "string"
},
"maps_url": {
"url": {
"type": "string"
},
"description": {
Expand Down
2 changes: 1 addition & 1 deletion src/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export function to_ics_event(e: EventRecord): EventAttributes {
title: e.title,
description: e.description,
location: e.location,
url: e.maps_url,
url: e.url,

organizer: ORGANIZER,
alarms: DEFAULT_ALARMS,
Expand Down
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ export interface EventRecord {

description?: string;
location?: string; // human-friendly address is usually enough
maps_url?: string; // event page
url?: string; // event page
}