TKW: add house rank filter to /houses, combinable with status#41
Merged
Conversation
- `Rank` dropdown filters by Royal, Lordly, Knightly, Other, Exiled, Extinct - backed by `?rank=` query param; ANDs with the existing status filter - `facetFiltered` folds status + rank into one set for count and region grouping - rank change resets to page 1 - export `HouseRank` type from `HouseRankSchema` in `lib/schemas.ts` - `.rankFilter`/`.rankLabel` styles matching the page-size control
✅ Deploy Preview for theknownworld ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rankfilter to/houses, combinable with the existing status filter?rank=query param, so filters are shareable and bookmarkableBehavior
?status=extinct&rank=lordlyshows extinct lordly housesfacetFilteredfolds status + rank into one set driving the count, list, and region groupingPlumbing
HouseRanktype fromHouseRankSchemainlib/schemas.tsapp/houses/page.tsxpasses each house'srankinto the list items.rankFilter/.rankLabelstyles matching the page-size controlTests
FilteredHouseListrank-filter suite: filtering, count, URL sync/hydration, page reset, combining with status, and region grouping