TKW: houses filter cleanup + zoomable timeline#43
Merged
Conversation
- drop `Any status` / `Standing` / `Extinct` control from `FilteredHouseList` - remove `status` `useQueryState` and the `?status=` query param - simplify `facetFiltered` to filter on `rank` only - delete dead `AllStatusIcon`, `StandingIcon`, `ExtinctIcon` - drop status-filter tests and the rank/status combination test
- add `.rankSelect` (scoped under `.rankFilter`) sizing the `<select>` to the 50px `SortToggle` / `ViewToggle` height - bump option text to `1.1rem` and pad for the dropdown arrow - keep the shared `listSearch.pageSizeSelect` compact for pagination
- split `buildTimeline` into serializable `prepareTimeline` and pure `layoutTimeline({ source, pxPerYear })`; `buildTimeline` stays a default-scale wrapper
- add `ZOOM_LEVELS` (`0.5x`–`16x`), `DEFAULT_ZOOM_INDEX`, and `yForYear` / `yearForY` helpers
- new client `TimelineExplorer` owns zoom state, floating `+` / `−` control, and `Ctrl` / `⌘` + wheel zoom
- pin the focal year across a re-layout so zoom stays put; keep the minimap ticks in sync
- clustering keys off the pixel gap, so higher zoom pulls grouped events into individual nodes; `16x` (`32px`/year) exceeds the `28px` gap, resolving each year on its own
- `/timeline` now feeds `prepareTimeline` into `TimelineExplorer`
- `public/battles/the-muddy-mess.jpg` for the existing battle entry
✅ Deploy Preview for theknownworld ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch work spanning the houses filters, the timeline, and one content asset.
Houses (
/houses)Any status/Standing/Extinct); the rank filter already carries anExtinctoption that covers the same intentSortToggle/ViewToggle(50px tall, larger option text), scoped so the shared pagination select stays compactTimeline (
/timeline)+/−control plusCtrl/⌘+ scroll, across0.5x–16x16x(32px/year, above the28pxgap) resolves each year on its own, breaking a busy pill like "33 events, 298-300 AC" into per-year entriesbuildTimelinesplit into serializableprepareTimeline+ purelayoutTimeline({ source, pxPerYear }), withbuildTimelinekept as a default-scale wrapper; newTimelineExplorerclient component owns the zoom stateContent
the-muddy-messTesting
bun run test(620 pass),bun run lint,bun run typecheck, andbun run buildall green, enforced by the pre-commit and pre-push hooks