TKW: character alias search, and fill missing aliases from AWOIAF#46
Merged
Conversation
- `filterByName` in `lib/search.ts` accepts an optional `aliases` array per item, ranked below name matches so a nickname like "Kingslayer" surfaces the right character without name matches losing priority - `CharacterItem` and `CharacterSuggestion` carry the full `aliases` array; `app/characters/page.tsx` and `app/characters/[slug]/page.tsx` pass it through - display unchanged — still shows only the first alias as a badge - adds alias-matching coverage to `lib/search.test.ts`, `CharacterSearchInput.test.tsx`, `FilteredCharacterList.test.tsx` - design spec at `docs/superpowers/specs/2026-07-13-character-alias-search-design.md`
- audited all 892 characters citing a `type: awoiaf` source against that page's infobox and lead prose - 141 characters gained new `aliases:` entries (bynames, epithets, alternate names) not previously recorded - existing aliases preserved and unioned, not replaced; formal titles/styles kept out of `aliases` - remaining characters either already had a complete alias list or have no recorded byname on their cited source
✅ Deploy Preview for theknownworld ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search
filterByNameinlib/search.tsranks against an optionalaliasesarray per item, with name matches always outranking alias-only matchesCharacterItemandCharacterSuggestioncarry the fullaliasesarray;app/characters/page.tsxandapp/characters/[slug]/page.tsxwire it throughhouses/weapons/dragonssearch unaffected (they never passaliases)Content
aliases:entries (bynames/epithets/alternate names) sourced from their AWOIAF infobox or lead prosealiasesDesign
docs/superpowers/specs/2026-07-13-character-alias-search-design.md