Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the build script configuration system by consolidating individual script calls into a centralized build script runner and updates the associated configuration files.
- Introduces a unified
buildScripts.jssystem to replace individual script executions - Updates package.json scripts to use the new
preparecommand pattern - Reorganizes dependency placement and disables unused exception handler script
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/buildScripts.js | Updates default script configuration with new scripts and improved formatting |
| scripts/build-config.json | Simplifies configuration to use new scripts and disables old exception handler |
| package.json | Replaces individual script calls with unified prepare command and reorganizes dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
digitalnomad91
force-pushed
the
chore/cleanup-vscode-settings
branch
from
952533d to
f0e45df
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| 'setupScreenRecording.js' | ||
| ] | ||
| // You can disable any by: { path: 'setupScreenRecording.js', enabled: false } | ||
| }; |
Check failure
Code scanning / CodeQL
Potential file system race condition High
| const existing = fs.readFileSync(path, 'utf8'); | ||
| if (existing === content) return false; // unchanged | ||
| } | ||
| fs.writeFileSync(path, content, 'utf8'); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
| }); | ||
|
|
||
| if (modified) { | ||
| fs.writeFileSync(androidManifestPath, manifestContent, "utf8"); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
| `class MainActivity : ReactActivity() {\n${injectionCode}\n` | ||
| ); | ||
|
|
||
| fs.writeFileSync(mainActivityPath, content, "utf8"); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
| override fun onBind(intent: Intent?): IBinder? = null | ||
| } | ||
| `; | ||
| fs.writeFileSync(servicePath, serviceCode, "utf8"); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
digitalnomad91
force-pushed
the
chore/cleanup-vscode-settings
branch
from
f0e45df to
fbbf4f2
Compare
- Reorganize build scripts to use unified prepare command - Move react-native-exception-handler to proper dependency order - Update script execution flow for better reliability - Remove deprecated build script references
- Update build-config.json to use new script structure - Disable legacy setupExceptionHandler.js in favor of config plugin - Improve buildScripts.js with better TypeScript support and error handling - Add support for conditional script execution
- Add prepareGoogleServices.js for handling google-services.json - Support base64 encoded content from environment variables - Add fallback support for legacy JSON string format - Include SHA256 hash verification for content validation
- Merge errorReporting.service.ts functionality into errorHandler.service.ts - Add comprehensive error reporting with circuit breaker pattern - Implement global JS and native error handlers - Add safe JSON serialization to prevent circular references - Include error simulation functions for testing - Remove dependency on react-native-exception-handler
- Archive nativeExceptionHandler.cjs as .old for reference - Functionality replaced by unified error handler service
- Remove scripts/setupExceptionHandler.js (replaced by config plugin) - Remove services/errorReporting.service.ts (merged into errorHandler.service.ts) - Remove utils/globalErrorhandler.ts (consolidated into errorHandler.service.ts) - Functionality preserved in unified error handler service
- Remove app/(tabs)/cellular.tsx.new - Remove app/(tabs)/jobs.tsx.new - Remove app/(tabs)/settings.tsx.new - These were temporary development files
- Update app.config.js with latest configuration changes
- Update app/(tabs)/index.tsx with latest changes - Update app/_layout.tsx to use new error handling approach - Update components/ErrorBoundary.tsx to integrate with unified error service
- Prevent VS Code settings with sensitive data from being committed - Protects database credentials and other sensitive configuration
digitalnomad91
added a commit
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.