Fix Exception from Header when cleaning up all code#912
Open
CrutchTheClutch wants to merge 1 commit intocodecadwallader:devfrom
Open
Fix Exception from Header when cleaning up all code#912CrutchTheClutch wants to merge 1 commit intocodecadwallader:devfrom
CrutchTheClutch wants to merge 1 commit intocodecadwallader:devfrom
Conversation
Owner
|
Thanks for opening the PR, I appreciate it. The code changes look pretty straight forward and good to me. May I ask what kind of testing you did with these changes? I'm not sure why the build failed, it just seems to have exited. Perhaps it was just an intermittent issue although we haven't usually seen those. |
Contributor
|
The build fails because it does not compile. Calling UIThread.Run on GetCurrentHeader does not return the expected return value. There is an easier way to fix that issue, we only need to call UIThread.Run inside UpdateFileHeader, like this: No further change is needed. I encountered the issue (not sure why it didn't show up during my dev, I tested it dozens and dozens of times) and this change fixed it. |
XavierMP14
approved these changes
Aug 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix #859