Skip to content

perf: use Clipboard API #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florian-lefebvre wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: use Clipboard API #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"buefy": "^0.9.13",
"codeceptjs": "^3.7.3",
"contributor-faces": "^1.1.0",
"copy-text-to-clipboard": "^3.2.0",
"electron-icon-builder": "^2.0.1",
"eslint": "^7.32.0",
"eslint-plugin-vue": "^7.20.0",
Expand Down
3 changes: 1 addition & 2 deletions src/components/Pause.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@

<script>
import Convert from 'ansi-to-html';
import copyToClipboard from 'copy-text-to-clipboard';

export default {
name: 'Pause',
Expand Down Expand Up @@ -268,7 +267,7 @@ export default {
},
methods: {
copy(text) {
copyToClipboard(text);
return navigator.clipboard.writeText(text);
},
selectedAction(actionText) {
const actions = this.$store.getters['cli/actions'];
Expand Down
3 changes: 1 addition & 2 deletions src/components/SnapshotSource.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
highlightElement,
highlightInIframe
} from '../services/selector-finder';
import copy from 'copy-text-to-clipboard';

const throttled = (delay, fn) => {
let lastCall = 0;
Expand Down Expand Up @@ -56,7 +55,7 @@ const handleIframeClick = (props, doc, window) =>
if (!props.enabledSelection) return;
const el = doc.elementFromPoint(e.x, e.y);
const shortestSelector = highlightElement(el, doc, window);
copy(shortestSelector);
return navigator.clipboard.writeText(shortestSelector);
});

export default {
Expand Down
5 changes: 2 additions & 3 deletions src/components/steps/Argument.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

<script>
// import {getSelectorString} from '../../services/selector';
import copyToClipboard from 'copy-text-to-clipboard';

export default {
name: 'Argument',
Expand All @@ -36,8 +35,8 @@ export default {
}
},
methods: {
copy() {
copyToClipboard(this.arg);
async copy() {
await navigator.clipboard.writeText(this.arg);
this.copyText = 'Copied!';
setTimeout(() => this.copyText = 'Copy', 3000);
},
Expand Down