Open
Conversation
codecodecoder78
requested changes
Nov 29, 2021
Owner
codecodecoder78
left a comment
codecodecoder78
left a comment
There was a problem hiding this comment.
Please try to run your code to ensure it at least starts
| def hello_world(): | ||
| return "Welcome to the database!" | ||
|
|
||
| app.run No newline at end of file |
Owner
There was a problem hiding this comment.
This does not do anything. Please look into the correct way to start the app on the notes. app.run is correct but needs more arguments
| def get_details(id): | ||
| try: | ||
| if request.method == 'GET': | ||
| return {"Status": "Success", "Data": db[id]} |
Owner
There was a problem hiding this comment.
What happens when id is not valid
| def get_details(id): | ||
| try: | ||
| if request.method == 'GET': | ||
| return {"Status": "Success", "Data": db[id]} |
Owner
There was a problem hiding this comment.
What happens when id is not valid
| def register(): | ||
| username = request.args.get('username') | ||
| pw = request.args.get('passwordHash') | ||
| credentials.append({"username": username, "passwordHash": pw}) |
Owner
There was a problem hiding this comment.
Defensive programming: Check that input is not "" or None to ensure that its a valid input
| token = request.args.get('token') | ||
| if token != None: | ||
| try: | ||
| user_details = jwt.decode(token, current_app.config['SECRET_KEY'], algorithms="HS256") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.