Open
Conversation
Contributor
Author
|
@JeffreySoriano5 if you have time it would be awesome if you could test this pr and give some feedback to the api. |
|
@sualko will give it a go |
Contributor
Author
|
Any update on this? |
Member
|
Hi Klaus, I still need to find some spare time to review this. At first glance, it looks good, but I can tell you I won't approve the PR until there are some unit tests and it gets rid of explicit casting (i.e., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a new option field which allows to set validation options and replaces the request fields with the converted values. If you do not like this behavior you can pass
convert = falseas validation option.@sergioalvz if you do not like to have a breaking change, we should set convert false as default.
Of course we need to create some tests for it.
Fix #9