fix: resolve silent data corruption bugs (P1)#337
Merged
Conversation
Fixes: - #42 Severity sort inverted: sort descending (Critical first) so max_findings truncation drops least important findings - #45 Security findings dropped on LLM failure: include security_findings in fallback condition and summary - #52 HashMap nondeterministic hash: sort HashMap entries by key before hashing for deterministic filenames - #53 Debt score trend wrong: compute recent_avg_quality from recent slice instead of overall average - #54 Category trend change inflated: build recent_category_counts from recent slice for accurate delta - #92 Config precedence inverted: env vars > config > auto-detect > defaults - #93 context_chain config ignored: copy context_chain from ReviewSection in merge_into - #96 Hook install overwrites existing hooks: use sentinel marker, backup non-cora hooks, compose wrapper Refs #333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 8 silent data corruption bugs that produce wrong output without any crash or error. All bugs are high-severity because they silently produce incorrect results.
Refs #333
Fixes
src/engine/rules/mod.rsmax_findingstruncation dropped the MOST important findingssrc/engine/review.rssrc/engine/debt_tracker.rssrc/engine/debt_tracker.rssrc/engine/debt_tracker.rssrc/config/loader.rssrc/config/schema.rscontext_chainsetting in.cora.yamlhad no effectsrc/hook/install.rsTesting
cargo clippy -- -D warningscleancargo fmtapplied