fix(web): ApiClientError undefined crash + type errors + frontend CI#275
Merged
Merged
Conversation
- P1: Add missing ApiClientError class definition (was accidentally deleted during v0.2.0 merge — caused login crash with 'ApiClientError is not defined' runtime error) - P1: Remove dead [id] issue route (superseded by [issueId]/events/[eventId] which correctly accesses event data via data.message) - P2: Fix debounceTimer null check — use undefined instead of null to match clearTimeout signature - P2: Extract vitest config from vite.config.ts to vitest.config.ts with proper SvelteKit alias resolution - P3: Add svelte-check and vitest to web-build CI pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P1 — Login crash fix
ApiClientErrorclass was accidentally deleted during v0.2.0 merge. It was used 9× inapi.ts(insideApiClient.request()and all standalone API functions). Restored the class definition beforeApiClientclass so it's available at runtime.P1 — Remove dead route
web/src/routes/(dashboard)/issues/[id]/+page.svelte— this route was superseded by[issueId]/events/[eventId]. The old route referencedevent.platformandevent.messagewhich don't exist on theStoredEventtype (backend proto hasdata: serde_json::Valueonly).P2 — Type fixes
nulltoundefined(matchesclearTimeoutsignature — no more TS error)vite.config.tsto dedicatedvitest.config.tswith proper SvelteKit alias resolution (,, ``)P3 — CI hardening
npm run check(svelte-check) andnpm test(vitest) toweb-buildCI jobVerification
svelte-check: 0 errorsvitest: 5/5 tests passvite build: success