feat: add memory_type to FTS5 index (#662)#664
Merged
Conversation
- Add memory_type column to FTS5 virtual table definition - Update all 3 sync triggers (INSERT, DELETE, UPDATE) to include memory_type - Add schema migration v13βv14: drop old FTS5 table/triggers, recreate with memory_type, rebuild index - Add tests: memory_type column search and rebuild verification
π Cora AI Code Reviewβ No issues found. Code looks good! Review powered by cora-cli Β· BYOK Β· MIT |
Collaborator
Author
CI Failure AnalysisError: Format check fail
Fix: Run Note: Check, Clippy, and Build passed on the latest run (29320742498). Only Format failed. |
Collaborator
Author
Updated CI Failure β Run 29321960300Format: β FIXEDBuild/Check/Clippy: β PASSTest: β FAIL β 4 migration tests brokenAll same root cause: Failed tests:
Fix: Update all 4 assertions from // edges.rs:1279, crud.rs:708, store.rs:1781, timeline.rs:299
assert_eq!(version, 14); // was 13Also check |
4 tests hardcoded v13 but CURRENT_SCHEMA_VERSION is now 14 (FTS5 memory_type migration). Updates assertion values and comment chain in crud.rs. Fixes #671
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add memory_type column to the FTS5 full-text search index so that keyword searches can match against memory types (fact, decision, procedure, etc.).
Changes
Closes #662