Lab-James#13
Conversation
fixed indentation in fp.js
test/test-fp.js
Outdated
| it('should return an array with doubled numbers', () => { | ||
| let validMap = fp.map([1,2,3,4], (n) => { return n * 2 }); | ||
| expect(validMap).to.be.an('array').that.includes.members([2,4,6,8]); | ||
| }) |
There was a problem hiding this comment.
According to your lint file you are missing many semicolons in this file. Need to make it so your eslint run is clear.
package.json
Outdated
| "scripts": { | ||
| "start": "node index.js", | ||
| "test": "mocha", | ||
| "lint": ".eslint ." |
There was a problem hiding this comment.
should be "eslint ." instead of ".eslint ."
lib/fp.js
Outdated
|
|
||
| exports.splice = (list, ...args) => { | ||
| if (!list) throw new Error('array not provided'); | ||
| if (typeof list === 'object') |
There was a problem hiding this comment.
This if block currently doesn't do anything. There aren't braces defining its area of code and there is nothing to the right of it on the same line. Need to fix or remove.
lib/fp.js
Outdated
|
|
||
| exports.map = (list, ...args) => { | ||
| if (!list) throw new Error('array not provided'); | ||
| if (typeof list === 'object') |
There was a problem hiding this comment.
This if block currently doesn't do anything. There aren't braces defining its area of code and there is nothing to the right of it on the same line. Need to fix or remove.
| let main = module.exports = () => { | ||
| let list = fp.splice(process.argv, 2); | ||
| list = fp.map(list, (word) => word.toUpperCase()); | ||
| let result = list.join(' '); |
There was a problem hiding this comment.
don't forget to at some point print them out to the screen in their capital form.
2 participants
No description provided.