lab-04-allan-andy-jonah#10
Open
ohjonah wants to merge 40 commits intocodefellows-javascript-401d17:masterfrom
Open
lab-04-allan-andy-jonah#10ohjonah wants to merge 40 commits intocodefellows-javascript-401d17:masterfrom
ohjonah wants to merge 40 commits intocodefellows-javascript-401d17:masterfrom
Conversation
Features/scaffold
Features/tests-for-BM-reader
added transformer files, tribute lou reed, input is 'colorArrayText'
Features/constructor test
Features/bitmap transform add in
Features/write to bmp
Uses a encoding 'hex' to convert hex string from object
typo in bitmap constructor makes value log wrong key value
Features/write to bmp
adds red transform
adds greyscale transform test
Adding in Allan's Code
Andys tests
Adding in Andy's Tests
Refactors Constructor and Helper Tests for Test Cases
brials
reviewed
Jul 31, 2017
| const expect = require('chai').expect; | ||
| const bitmapFileHelper = require(`${__dirname}/../lib/bitmap-file-helper.js`); | ||
|
|
||
| describe('Bitmap File Helper', function() { |
There was a problem hiding this comment.
At some point you should test the main point of your program which is the writing new files after the transform.
brials
reviewed
Jul 31, 2017
| bitmapFileHelper(`${__dirname}/../assets/palette-bitmap.bmp`, function(err, data) { | ||
| if(err) throw err; | ||
| let result = new bitmapConstructor.Bitmap(data); | ||
| expect(result).to.be.an('object'); |
There was a problem hiding this comment.
being an object is a pretty simple condition. You may want to test properties on the object that you create.
brials
reviewed
Jul 31, 2017
| const infraredTransform = require(`${__dirname}/lib/infrared-transform.js`); | ||
|
|
||
|
|
||
| bitmapFileHelper(`${__dirname}/assets/palette-bitmap.bmp`, function(err, data) { |
There was a problem hiding this comment.
These function calls could be handled modularly in fileHelper. That would allow you to test your whole writing file path easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really awesome group project, with very good group synergy and mob/pair programming through most of the codebase. Need to add tests, but wanted to make PR available so that group members could get their submissions in, while going for a retry later.