nathan-sharmarke-bret#11
Open
nharren wants to merge 38 commits intocodefellows-javascript-401d17:masterfrom
Open
nathan-sharmarke-bret#11nharren wants to merge 38 commits intocodefellows-javascript-401d17:masterfrom
nharren wants to merge 38 commits intocodefellows-javascript-401d17:masterfrom
Conversation
Adds scaffolding.
…tmap in a callback.
Features/read file header
Features/read color table
Features/read pixel array
Features/dib header and fixes
Refactor/bitmap callback
added get pixel function
Adds event emitter.
Features/bitmap transformer
Features/more transforms
Features/tests
Features/bitmap headers
Features/transforms and docs
Makes reading bitmaps endian agnostic.
brials
reviewed
Jul 31, 2017
| while (transforms.length > 0) { | ||
| let transform = transforms.shift(); | ||
| let transformParts = transform.split(':'); | ||
|
|
There was a problem hiding this comment.
while this switch statement works for what you are accomplishing another way to handle this that would only take up a single line of code and would keep it from growing out of control if you had 100+ transformations would be to access the property of the object. So instead of passing in a string of bw or hflip you could pass in the name of the property and just access the bitmapproperty. For the items with parameters you can have another variable you pass in to bitmapproperty and on the ones that don't need the parameter you can ignore it as they won't accept a parameter anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.