Lab 11 Assignment -- Nassir Isaf#10
Open
njisaf wants to merge 25 commits intocodefellows-seattle-javascript-401d10:masterfrom
Open
Lab 11 Assignment -- Nassir Isaf#10njisaf wants to merge 25 commits intocodefellows-seattle-javascript-401d10:masterfrom
njisaf wants to merge 25 commits intocodefellows-seattle-javascript-401d10:masterfrom
Conversation
Scaffolding
Server post-route constructor and error mware done
Fetch logic in place
Delete functions finished, I think
Shit tests working; forgot to do put
PUT seems to work! Now to test
All tests but one key one passing
Fixed linter errors
Refactored, original tests working
Raziyehbazargan
pushed a commit
to Raziyehbazargan/lab-11-12-express-api
that referenced
this pull request
Sep 27, 2016
…fellows/lec-09 added lecture-09
stefuhnee
reviewed
Sep 27, 2016
|
|
||
| ## Express API -- CatAPI 2.0 | ||
|
|
||
| CatAPI is proud to announce CatAPI 2.0! CatAPI 2.0 is not GUARANTEED to have way fewer crippling bugs! |
stefuhnee
reviewed
Sep 27, 2016
|
|
||
| # What's new in 2.0 | ||
|
|
||
| CatAPI 2.0 now accepts PUT methods! If you have a cat and for some reason want to change its name, you may now do so. If your cat has changed its breed, CatAPI 2.0 now also permits CHANGING BREEDS. CatAPI 2.0 is the FIRST and ONLY cat-based API to have this feature! CatAPI supports equality. |
Delete tests working
stefuhnee
reviewed
Sep 27, 2016
|
|
||
| CatAPI 2.0 now accepts PUT methods! If you have a cat and for some reason want to change its name, you may now do so. If your cat has changed its breed, CatAPI 2.0 now also permits CHANGING BREEDS. CatAPI 2.0 is the FIRST and ONLY cat-based API to have this feature! CatAPI supports equality. | ||
|
|
||
| Also new in 2.0: Closing the server will now NOT erase all your data! This was our most requested feature, proving once again that customers come first at CatAPI. |
stefuhnee
reviewed
Sep 27, 2016
|
|
||
| IMPORTANT: Don't get the easy-to-remember ID number wrong when using PUT. Trust us on this... | ||
|
|
||
| CatAPI can only record the name and breed of your cats. Attempting to enter additional information will return an error message. CatAPI was the first cat-based API to break in this fashion, and our competitors are COPYCATS. |
stefuhnee
reviewed
Sep 27, 2016
| const eslint = require('gulp-eslint'); | ||
| const mocha = require('gulp-mocha'); | ||
|
|
||
| gulp.task('hello', function(){ |
stefuhnee
reviewed
Sep 27, 2016
| 'use strict'; | ||
|
|
||
| const Promise = require('bluebird'); | ||
| const debug = require('debug')('note:storage'); |
There was a problem hiding this comment.
you would want this to be 'cat:storage'
stefuhnee
reviewed
Sep 27, 2016
| const createError = require('http-errors'); | ||
| const fs = Promise.promisifyAll(require('fs'), {suffix: 'Prom'}); | ||
| const del = require('del'); | ||
| const mkdirp = Promise.promisifyAll(require('mkdirp'), {suffix: 'Prom'}); |
There was a problem hiding this comment.
mkdirp doesn't require a prom suffix.
stefuhnee
reviewed
Sep 27, 2016
| "mkdirp": "^0.5.1", | ||
| "morgan": "^1.7.0", | ||
| "node-uuid": "^1.4.7", | ||
| "superagent": "^2.3.0" |
There was a problem hiding this comment.
superagent is technically a dev dependency.
Readme and cleanup
stefuhnee
reviewed
Sep 28, 2016
| .catch(err => Promise.reject(createError(404, err.message))); | ||
| }; | ||
|
|
||
| // exports.availIDs = function(schemaName) { |
stefuhnee
reviewed
Sep 28, 2016
| }) | ||
| .catch(err => done(err)); | ||
| }); | ||
| // after(done => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.