Lab 36/37 - Elizabeth#2
Open
Tenlia wants to merge 3 commits intocodefellows-seattle-javascript-401d10:masterfrom
Open
Lab 36/37 - Elizabeth#2Tenlia wants to merge 3 commits intocodefellows-seattle-javascript-401d10:masterfrom
Tenlia wants to merge 3 commits intocodefellows-seattle-javascript-401d10:masterfrom
Conversation
stefuhnee
reviewed
Nov 10, 2016
| }, | ||
| files: [ | ||
| 'app/entry.js', | ||
| 'client-test/**/*-test.js', |
There was a problem hiding this comment.
Good work changing these paths to point to your client-test directory :)
stefuhnee
reviewed
Nov 10, 2016
| let googleAuthAccessType = 'access_type=offline'; | ||
| let googleAuthPrompt = 'prompt=consent'; | ||
|
|
||
| this.googleAuthURL = `${googleAuthBase}?${googleAuthResponseType}&${googleAuthClientID}&${googleAuthScope}&${googleAuthRedirectURI}&${googleAuthAccessType}&${googleAuthPrompt}`; |
There was a problem hiding this comment.
Nice work constructing the URL for your anchor tag :)
stefuhnee
reviewed
Nov 10, 2016
| }) | ||
| .then(user => user.generateToken()) | ||
| .then(token => { | ||
| res.redirect(`/?token=${token}`); |
There was a problem hiding this comment.
Good work passing the token back to the client via a redirect with the token in the query string :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.