Bluescale transformer#19
Open
maschigokae wants to merge 27 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:bluescale
Open
Bluescale transformer#19maschigokae wants to merge 27 commits intocodefellows-seattle-javascript-401d12:masterfrom BatemanVO:bluescale
maschigokae wants to merge 27 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:bluescale
Conversation
Creates an object that then stores the color table as an array of bytes, offset from 54 to 1078.
Bitmap constructor
Required in fs, bitmap-constructor, and invert-colors. Created a color inverter test starting with the invertColorTable function. First it block checks if the values are within the range of 0-255.
…colorTable is equal to 255 - the new buffer's table.
…ap file's buffer and replace its values.
Moved done() call to prevent false positives. Changed test to account for color table positions in buffer instead of looking for values of a nonexistent array.
For loop was not running - needed to check data.colorTable.length, not data.length.
Getting timeout errors on final test.
Inverter-test was trying to find a type of buffer, but couldn't figure out the logic for it. Instead checks that the buffer has a length greater than 0.
Color inverter
The linter is complaining about a variable being defined but not used, but it's a single function to export. Brian has already given the thumbs up on this particular error being ignored.
A small module that slices the command line arguments to remove node and -filename- from process.argv.
Cli interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create bluescale transformer module.