04-Lab (Hawa Steven Caleb) by maschigokae · Pull Request #20 · codefellows-seattle-javascript-401d12/04-bitmap-transformer

maschigokae · 2016-12-12T23:48:34Z

Lab #4 Bitmap transformer, by Hawa, Steven and Caleb.

Creates an object that then stores the color table as an array of bytes, offset from 54 to 1078.

Bitmap constructor

Required in fs, bitmap-constructor, and invert-colors. Created a color inverter test starting with the invertColorTable function. First it block checks if the values are within the range of 0-255.

…colorTable is equal to 255 - the new buffer's table.

… created.

…ap file's buffer and replace its values.

Moved done() call to prevent false positives. Changed test to account for color table positions in buffer instead of looking for values of a nonexistent array.

For loop was not running - needed to check data.colorTable.length, not data.length.

Getting timeout errors on final test.

Inverter-test was trying to find a type of buffer, but couldn't figure out the logic for it. Instead checks that the buffer has a length greater than 0.

Color inverter

The linter is complaining about a variable being defined but not used, but it's a single function to export. Brian has already given the thumbs up on this particular error being ignored.

A small module that slices the command line arguments to remove node and -filename- from process.argv.

Cli interface

… grayscale-colors.js file.

Finished writing tests for the grayscale transformers, and edited the…

Bluescale transformer

Comments and readme

Psychedelic transform

bnates

Great job on this project, y'all did great!

bnates · 2016-12-19T18:23:36Z

bitmap-steven-hawa-caleb/bitmap-transformer.js

+const transformArray = cliInterpreter(process.argv);
+
+// Series of if statements checking for the words "invert," "grayscale," and "bluescale". If they were passed in, use the appropriate module method.
+if (transformArray.some(function(element) { return element.toLowerCase() === 'invert'; })) {


@maschigokae @BatemanVO @abdih17 great use of the some array method in conjunction with your command line arguments

bnates · 2016-12-19T18:25:15Z

bitmap-steven-hawa-caleb/bitmap-transformer.js

+const invert = require('./lib/invert-colors.js');
+const grayscale = require('./lib/grayscale-colors.js');
+const bluescale = require('./lib/bluescale-colors.js');
+const psychedelic = require('./lib/psychedelic.js');


@maschigokae @BatemanVO @abdih17 require statements look good, along with the separation of your transform helpers by containing them in a lib directory

bnates · 2016-12-19T18:25:43Z

bitmap-steven-hawa-caleb/gulpfile.js

+  gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']);
+});
+
+gulp.task('default', ['dev']);


@maschigokae @BatemanVO @abdih17 gulpfile.js looks good

bnates · 2016-12-19T18:27:46Z

bitmap-steven-hawa-caleb/lib/bluescale-colors.js

+'use strict';
+
+const fs = require('fs');
+const bmp = require(`${__dirname}/../model/bitmap-constructor.js`);


@maschigokae @BatemanVO @abdih17 - no need to use __dirname for absolute paths when requiring in a custom module - for custom module require imports, just use the relative path

bnates · 2016-12-19T18:29:27Z

bitmap-steven-hawa-caleb/lib/bluescale-colors.js

+        if (blueAvg > 255) blueAvg = 255;
+        blueScaleBuffer[54 + index] = blueAvg;
+      }
+      callback(null, blueScaleBuffer);


@maschigokae @BatemanVO @abdih17 great use of the NodeJS (err, result) callback pattern along with passing in a null value as the error parameter

bnates · 2016-12-19T18:51:49Z

bitmap-steven-hawa-caleb/lib/psychedelic.js

+      if (callback) callback();
+    });
+  });
+};


@maschigokae @BatemanVO @abdih17 psychedlic transform module looks good

bnates · 2016-12-19T18:52:13Z

bitmap-steven-hawa-caleb/model/bitmap-constructor.js

+// The DIB BITMAPINFOHEADER contains this information at an offset of 46 bytes, so if we use the buffer method readInt32LE(46), we get back a value
+// of 256, meaning this bitmap file has 256 colors.
+// Since each color is 4 bytes, we would expect a color table to be (256 x 4 = 1024) bytes in size. This matches our expected range of 54 bytes to 1078
+// bytes (1078 - 54 = 1024), so we can be sure we have correctly selected the color table from our buffer.


@maschigokae @BatemanVO @abdih17 - fantastic comments!

bnates · 2016-12-19T18:52:28Z

bitmap-steven-hawa-caleb/model/bitmap-constructor.js

+  fs.readFile(`${__dirname}/../../img/palette-bitmap.bmp`, function(err, data) {
+    if (err) throw err;
+    bmp.colorTable = data.slice(54, 1078);
+    return callback(null, bmp);


@maschigokae @BatemanVO @abdih17 good callback pattern here

bnates · 2016-12-19T18:55:45Z

bitmap-steven-hawa-caleb/test/grayscale-test.js

+    it('Should transform data into a grayscale.', function(done) {
+      grayscaleColors.grayscaleTransform(function(err, buffer) {
+        var checkOutliers = false;
+        for (var i = 54; i < 1078; i+=4) {


@maschigokae @BatemanVO @abdih17 best to abstract your loop logic out of the test, we'll talk more about this next week

bnates · 2016-12-19T18:56:34Z

bitmap-steven-hawa-caleb/test/psychedelic-test.js

+      });
+    });
+  });
+});


@maschigokae @BatemanVO @abdih17 generally speaking, tests look good - a few pieces of logic that should be tested themselves and/or abstracted into their own modules - we'll discuss more next week as we get heavier into fully testing our API

BatemanVO and others added 30 commits December 9, 2016 10:02

Created initial scaffold.

a0c909b

Created bitmap constructor module.

d41b72e

Creates an object that then stores the color table as an array of bytes, offset from 54 to 1078.

Added constructor test. Checked for passing.

2489d1a

Added a console.dir(bitmap) to show colorTable for testing purposes.

38a98c2

Created lib directory, added placeholder files.

800ebba

Added comments explaining the slice range in bitmap-constructor.js.

9e50f46

Merge pull request #1 from BatemanVO/bitmap_constructor

4a6a4de

Bitmap constructor

Started writing tests.

c02b605

Required in fs, bitmap-constructor, and invert-colors. Created a color inverter test starting with the invertColorTable function. First it block checks if the values are within the range of 0-255.

Added second it block that checks if the bitmap-constructor object's …

3275fcf

…colorTable is equal to 255 - the new buffer's table.

Added test to check if an inverted-palette.bmp image was successfully…

a7bb5ff

… created.

Properly imported chai. Ran tests, failed as expected.

756b176

Fixed formatting in test file. Wrote invertColorTable function.

3989a1e

Updated invertColorTable function to make a copy of the original bitm…

aeb4fc4

…ap file's buffer and replace its values.

Updated inverter test.

ab76ccf

Moved done() call to prevent false positives. Changed test to account for color table positions in buffer instead of looking for values of a nonexistent array.

Fixed invertColorTable function.

392c7e6

For loop was not running - needed to check data.colorTable.length, not data.length.

Created createInvertedBitmap function. Changed test name to reflect.

9302765

Getting timeout errors on final test.

Fixed issues with last test.

5deef24

Inverter-test was trying to find a type of buffer, but couldn't figure out the logic for it. Instead checks that the buffer has a length greater than 0.

Merge pull request #2 from BatemanVO/color_inverter

9c1272a

Color inverter

Created Gulp file. Disabled eslint on bitmap-constructor.

3bb8867

The linter is complaining about a variable being defined but not used, but it's a single function to export. Brian has already given the thumbs up on this particular error being ignored.

Created cli-interpreter.js.

a1df353

A small module that slices the command line arguments to remove node and -filename- from process.argv.

Updated bitmap-transformer.js to call transforms based on CLI arguments.

32f3f2f

Created test for cli-interpreter.

d03e677

Merge pull request #3 from BatemanVO/cli_interface

a92458b

Cli interface

Fixed grayscale transformer and finish tests.

749685e

Added comments to personally-written modules.

c3391fe

Added README.md file for how to use the Node app.

32c2b11

add bluescale transform application

fc1886d

add cli handler for bluescale transform app

664f075

Finished writing tests for the grayscale transformers, and edited the…

a2f1dac

… grayscale-colors.js file.

Merge pull request #4 from BatemanVO/grayscale-testing

7cf2b8b

Finished writing tests for the grayscale transformers, and edited the…

maschigokae and others added 14 commits December 12, 2016 12:46

adjusted color palatte offset

5b2e204

Amended the README to mention npm i.

480ca91

Refactored bitmap-transformer.js to prevent anticipated merge conflict.

0ab2204

Merge pull request #5 from BatemanVO/bluescale

62c50c9

Bluescale transformer

Merge pull request #6 from BatemanVO/comments_and_readme

7edb5dd

Comments and readme

added psychedelic transform, 0-out rgb values over 200

9e12bc6

update cli functionality with psychedelic transform tool

f2c6cfd

discard commented-out code

9cfcb62

add psychedelic test

290c7f7

refactor psychedelic transform to start at color table position

6aa8d77

remove console.log

6f57281

Merge pull request #7 from BatemanVO/psychedelic-transform

a30035f

Psychedelic transform

Update README.md

6d5d7f6

Update README.md

0ed29fc

bnates reviewed Dec 19, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

04-Lab (Hawa Steven Caleb)#20

04-Lab (Hawa Steven Caleb)#20
maschigokae wants to merge 44 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:master

maschigokae commented Dec 12, 2016

Uh oh!

bnates left a comment

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

bnates Dec 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

maschigokae commented Dec 12, 2016

Uh oh!

bnates left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants