lab-04 evan-erick-michael#25
lab-04 evan-erick-michael#25kcirekcom wants to merge 59 commits intocodefellows-seattle-javascript-401d12:masterfrom
Conversation
added BMP file to our root
Evan working branch
cleaned up the file-reader and pushed our information into the object
adding some notes
managed to get the data broken down into manageable chunks
Michael branch
Michael branch
changed to relative path and fixed typo, new image added
adding grayscale functionality and partial constructor changeover
created inversion transformer
Erick newbranch
adding scaling-read.js
adding most recent constructor
building constructors
write file
created forEach functions for each array
refactored code grayscale
refactored code again
created README markdown file
Erick newbranch
more tests so fucking frustrated
rescaffolded the entire directory and deleted images
bnates
left a comment
bnates
left a comment
There was a problem hiding this comment.
Nice job on this assignment - there's a few areas that could be cleaned up and condensed - outside of that, nice job!
| *.tgz | ||
|
|
||
| # Yarn Integrity file | ||
| .yarn-integrity |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 no need for 2 .gitignore files ;)
|
|
||
| ### How do I use this app? | ||
|
|
||
| If you intend to use this app, you should clone this repository and run the command `npm i` in your terminal to install all of the dependencies for the development environment. Once everything has been installed, navigate to the lib/ folder located within the app. While in this folder, you must run the command `node bmp-reader.js`. The result of this command will create new bitmap image files, which are located inside of the img/ folder. |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 README.md looks good!
| gulp.watch(['**/*.js','!node_modules/**'], ['lint', 'test']); | ||
| }); | ||
|
|
||
| gulp.task('default', ['dev']); |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 gulpfile.js looks good!
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 overall, the bitmapReader module functionality looks good - that said, there is a substantial amount of repeated code along with a series of antipatterns and related functions that could be refactored to be contained using the constructor pattern and a few prototype methods - let's set aside 15 minutes or so to chat after the holiday break and I'll give you some pointers on how to refactor this and clean it up
| this.transformedRandomPalette = []; | ||
| this.transformedPaletteInverted = []; | ||
| this.transformedScaledPalette = []; | ||
| }; |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 bitmap-contstructor looks good! It could be useful to also save the raw buffer as a property on the bitmap constructor as well (ex: this.bitmap = data)
| "gulp-mocha": "^3.0.1", | ||
| "mocha": "^3.2.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 package.json and associated devDependencies look good!
| let transformedImage = fs.readFileSync('../img/colorScale-bmp.bmp'); | ||
| expect(image).to.not.equal(transformedImage); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@kcirekcom @jmpaik @EWPS07 your tests look good but are a little light - we'll chat about this when we discuss the refactor pointed out above - that said, great job using let instead of var for proper block scoping in your tests
4 participants
No description provided.