-
Notifications
You must be signed in to change notification settings - Fork 12
Lab - Britt #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
goodbye-internet
wants to merge
10
commits into
codefellows-seattle-javascript-401d12:master
Choose a base branch
from
goodbye-internet:http
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lab - Britt #7
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2668250
Adding gulpfile
d1a63b2
Adding package.json
82ed286
Adding initial README.md
6c02be9
Adding data.json
4159568
Adding eslinter.
ab6416c
Adding .gitignore
5f08617
Adding POST body parser.
49bbe6a
Working GET and POST.
a93f1ea
Updating README
b9639c8
Updating try and catch with the POST request. Works much better now.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "rules": { | ||
| "no-console": "off", | ||
| "indent": [ "error", 2 ], | ||
| "quotes": [ "error", "single" ], | ||
| "semi": ["error", "always"], | ||
| "linebreak-style": [ "error", "unix" ] | ||
| }, | ||
| "env": { | ||
| "es6": true, | ||
| "node": true, | ||
| "mocha": true, | ||
| "jasmine": true | ||
| }, | ||
| "ecmaFeatures": { | ||
| "modules": true, | ||
| "experimentalObjectRestSpread": true, | ||
| "impliedStrict": true | ||
| }, | ||
| "extends": "eslint:recommended" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # Created by https://www.gitignore.io/api/node,macos,vim,git | ||
|
|
||
| ### Node ### | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
|
|
||
| # Runtime data | ||
| pids | ||
| *.pid | ||
| *.seed | ||
| *.pid.lock | ||
|
|
||
| # Directory for instrumented libs generated by jscoverage/JSCover | ||
| lib-cov | ||
|
|
||
| # Coverage directory used by tools like istanbul | ||
| coverage | ||
|
|
||
| # nyc test coverage | ||
| .nyc_output | ||
|
|
||
| # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) | ||
| .grunt | ||
|
|
||
| # node-waf configuration | ||
| .lock-wscript | ||
|
|
||
| # Compiled binary addons (http://nodejs.org/api/addons.html) | ||
| build/Release | ||
|
|
||
| # Dependency directories | ||
| node_modules | ||
| jspm_packages | ||
|
|
||
| # Optional npm cache directory | ||
| .npm | ||
|
|
||
| # Optional eslint cache | ||
| .eslintcache | ||
|
|
||
| # Optional REPL history | ||
| .node_repl_history | ||
|
|
||
| # Output of 'npm pack' | ||
| *.tgz | ||
|
|
||
| # Yarn Integrity file | ||
| .yarn-integrity | ||
|
|
||
|
|
||
|
|
||
| ### macOS ### | ||
| *.DS_Store | ||
| .AppleDouble | ||
| .LSOverride | ||
|
|
||
| # Icon must end with two \r | ||
| Icon | ||
| # Thumbnails | ||
| ._* | ||
| # Files that might appear in the root of a volume | ||
| .DocumentRevisions-V100 | ||
| .fseventsd | ||
| .Spotlight-V100 | ||
| .TemporaryItems | ||
| .Trashes | ||
| .VolumeIcon.icns | ||
| .com.apple.timemachine.donotpresent | ||
| # Directories potentially created on remote AFP share | ||
| .AppleDB | ||
| .AppleDesktop | ||
| Network Trash Folder | ||
| Temporary Items | ||
| .apdisk | ||
|
|
||
|
|
||
| ### Vim ### | ||
| # swap | ||
| [._]*.s[a-w][a-z] | ||
| [._]s[a-w][a-z] | ||
| # session | ||
| Session.vim | ||
| # temporary | ||
| .netrwhist | ||
| *~ | ||
| # auto-generated tag files | ||
| tags | ||
|
|
||
|
|
||
| ### Git ### | ||
| *.orig |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| ### HTTP Cowsay Project | ||
|
|
||
| This is a fun project where you can practice GET and POST requests using HTTPIE and the Cowsay npm package! Woo! | ||
|
|
||
| A visualization of the HTTP Cowsay project may be seen below (credit to [Brian Nations](https://github.com/bnates)): | ||
|
|
||
|  | ||
|
|
||
| ### Get the Project Running | ||
|
|
||
| To get this project running, type the following in your command line: | ||
|
|
||
| 1. `git clone https://github.com/brittdawn/07-vanilla-http-server.git` | ||
| 2. `cd 07-vanilla-http-server.git` | ||
| 3. `npm i` | ||
| 4. `brew install httpie` | ||
| 4. `node server.js` | ||
|
|
||
| You will now see the phrase "server is up: 3000" if you have not already specified a port number. | ||
|
|
||
| ### Test the Vanilla HTTP Server | ||
|
|
||
| 1. Open a new terminal located at the root of this project and type `http localhost:3000/` | ||
| 2. You should get a response saying 'hello from my server' | ||
| 3. Play with the GET and POST requests below. | ||
|
|
||
| ### Interacting with HTTP Endpoints | ||
|
|
||
| To make an initial GET request, type this in the terminal: `http localhost:3000/cowsay?text=hi`. A cow will appear with a text of hi. If you have made a bad request, a sad Ren will appear. You can change the text to whatever you would like. | ||
|
|
||
| To make a POST request, type this in the terminal: `http POST localhost:3000/cowsay text=hello`. You can change the text to whatever you would like. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "text": "hello" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| 'use strict'; | ||
|
|
||
| const gulp = require('gulp'); | ||
| const eslint = require('gulp-eslint'); | ||
| const mocha = require('gulp-mocha'); | ||
| const cache = require('gulp-cache'); | ||
| const istanbul = require('gulp-istanbul'); | ||
|
|
||
| gulp.task('pre-test', function() { | ||
| return gulp.src(['./lib/*.js', './model/*.js', '!node_modules/**']) | ||
| .pipe(istanbul()) | ||
| .pipe(istanbul.hookRequire()); | ||
| }); | ||
|
|
||
| gulp.task('test', ['pre-test'], function() { | ||
| gulp.src('./test/*-test.js', { read: false}) | ||
| .pipe(mocha({ report: 'spec'})) | ||
| .pipe(istanbul.writeReports()) | ||
| .pipe(istanbul.enforceThresholds({thresholds: {global: 90}})); | ||
| }); | ||
|
|
||
| gulp.task('lint', function() { | ||
| return gulp.src(['**/*.js', '!node_modules/**']) | ||
| .pipe(eslint()) | ||
| .pipe(eslint.format()) | ||
| .pipe(eslint.failAfterError()); | ||
| }); | ||
|
|
||
| gulp.task('dev', function() { | ||
| gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']); | ||
| }); | ||
|
|
||
| gulp.task('default', ['dev']); | ||
|
|
||
| gulp.task('clear', function (done) { | ||
| return cache.clearAll(done); | ||
| }); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome gulp file. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = function(req, callback) { | ||
| req.body = ''; | ||
|
|
||
| req.on('data', function(data) { | ||
| req.body += data.toString(); | ||
| }); | ||
|
|
||
| req.on('end', function() { | ||
| try { | ||
| req.body = JSON.parse(req.body); | ||
| callback(null, req.body); | ||
| } catch (err) { | ||
| callback(err); | ||
| } | ||
| }); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "name": "http", | ||
| "version": "1.0.0", | ||
| "description": "Fun Cowsay HTTP Lab.", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "cowsay": "^1.1.9", | ||
| "querystring": "^0.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "chai": "^3.5.0", | ||
| "eslint": "^3.12.1", | ||
| "gulp": "^3.9.1", | ||
| "gulp-cache": "^0.4.5", | ||
| "gulp-eslint": "^3.0.1", | ||
| "gulp-istanbul": "^1.1.1", | ||
| "gulp-mocha": "^3.0.1", | ||
| "mocha": "^3.2.0" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| 'use strict'; | ||
|
|
||
| const http = require('http'); | ||
| const url = require('url'); | ||
| const querystring = require('querystring'); | ||
| const cowsay = require('cowsay'); | ||
| const parseBody = require('./lib/parse-body.js'); | ||
| const PORT = process.env.PORT || 3000; | ||
|
|
||
| const server = http.createServer(function(req, res) { | ||
| req.url = url.parse(req.url); | ||
| req.url.query = querystring.parse(req.url.query); | ||
|
|
||
| if (req.url.pathname === '/'){ | ||
| res.writeHead(200, { | ||
| 'Content-Type': 'text/plain' | ||
| }); | ||
| res.write('hello from my server'); | ||
| return res.end(); | ||
| } | ||
|
|
||
| if (req.method === 'GET' && req.url.pathname === '/cowsay') { | ||
| try { | ||
| res.writeHead(200, { | ||
| 'Content-Type': 'text/plain' | ||
| }); | ||
| res.write(cowsay.say(req.url.query)); | ||
| } catch (err) { | ||
| res.writeHead(400); | ||
| res.write(cowsay.think({ | ||
| text: 'Bad Request. Ren is sad. You could try: http localhost:3000/cowsay?text=hi', | ||
| f: 'ren' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yesssss! Love it. |
||
| })); | ||
| } | ||
| return res.end(); | ||
| } | ||
|
|
||
| if(req.method === 'POST' && req.url.pathname === '/cowsay') { | ||
| parseBody(req, function(err) { | ||
| if (err) return console.error(err); | ||
| if(req.body.text) { | ||
| try { | ||
| res.writeHead(200,{ | ||
| 'Content-Type': 'text/plain' | ||
| }); | ||
| res.write(cowsay.say({ | ||
| text: req.body.text | ||
| })); | ||
| return res.end(); | ||
| } catch (err) { | ||
| res.writeHead(400); | ||
| res.write(cowsay.think({ | ||
| text: 'Bad Request. Daemon is happy. Try again.', | ||
| f: 'daemon' | ||
| })); | ||
| return res.end(); | ||
| } | ||
| } | ||
| return res.end(); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| server.listen(PORT, () => { | ||
| console.log('server is up:', PORT); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the docs!