Lab 9 - Britt#20
Open
goodbye-internet wants to merge 21 commits intocodefellows-seattle-javascript-401d12:masterfrom
goodbye-internet:16-persistent-storage
Open
Lab 9 - Britt#20goodbye-internet wants to merge 21 commits intocodefellows-seattle-javascript-401d12:masterfrom goodbye-internet:16-persistent-storage
goodbye-internet wants to merge 21 commits intocodefellows-seattle-javascript-401d12:masterfrom
goodbye-internet:16-persistent-storage
Conversation
added 21 commits
December 14, 2016 17:44
kaylynyuh
reviewed
Dec 19, 2016
| Transfer-Encoding: chunked | ||
|
|
||
| not found | ||
| ``` |
kaylynyuh
reviewed
Dec 19, 2016
| if (!id) return Promise.reject(new Error('expected id')); | ||
|
|
||
| return fs.unlinkProm(`${__dirname}/../data/${schemaName}/${id}.json`) | ||
| .then( () => id) |
There was a problem hiding this comment.
This Promise is getting passed in the route so your .then isn't necessary here, just the .catch should be good :)
kaylynyuh
reviewed
Dec 19, 2016
| }); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @geoffsimons for posting in Slack that you can delete a file using
fs.unlink. That was not intuitive in the Node docs - as Steven originally pointed out.