lab-steven#1
Open
BatemanVO wants to merge 35 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:master
Open
lab-steven#1BatemanVO wants to merge 35 commits intocodefellows-seattle-javascript-401d12:masterfrom BatemanVO:master
BatemanVO wants to merge 35 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:master
Conversation
Created post route, started work on put route.
As of version 4.0, you need to explicitly pass in the new:true option with a findByIdAndUpdate and findOneAndUpdate call.
Also added GET test with no ID passed in.
Updated PUT route to throw 400 error if no content is passed in.
Amended student.js to properly save the tempStudent, not the tempAssignment. Amended assignment-route.js to throw the correct error codes. Amended student-route.js to properly .populate on get requests. Added assignment-route POST tests. Amended server.js to require in assignment router.
giodamelio
reviewed
Jan 2, 2017
| This is an app that will allow you to practice POST, PUT, GET, and DELETE requests using HTTPIE against a database created with MongoDB that tracks a single resource, in the form of students with a name and age field. | ||
|
|
||
| ###Installation | ||
| ####Dependencies |
There was a problem hiding this comment.
You probably shouldn't list httpie as a hard dependency, since you don't really NEED it for this project to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.