Lab 21 jonny#22
Open
jonathanheemstra wants to merge 27 commits intocodefellows-seattle-javascript-401d12:masterfrom
Open
Lab 21 jonny#22jonathanheemstra wants to merge 27 commits intocodefellows-seattle-javascript-401d12:masterfrom
jonathanheemstra wants to merge 27 commits intocodefellows-seattle-javascript-401d12:masterfrom
Conversation
scaffold files and set up package.json
set up and test webconfig
inital buildout of entry.js
built out and tested cowsay app
Buildout scss
add a readme
refactor entry js
updated package.json
update index.html
add in undo function
refactor webpack config file
kaylynyuh
reviewed
Jan 19, 2017
| this.routes = [ | ||
| { | ||
| name: 'about', | ||
| url: 'https://github.com/jonathanheemstra/20-intro_to_angular_and_webpack/blob/master/README.md' |
There was a problem hiding this comment.
Awesome! I like how you included additional functionality in the navbar to redirect to your GH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question:
Why does the
ng-init="cowsayCtrl.current = 'vader'"have to be added to the section tag instead of being added to the actual select tag? I initial had tried adding it to the select tag and the option tag and neither worked as expected.Observation:
Using the
controller asconstruct provided by angular makes creating and managing controllers so much easier.The biggest issues I encountered during the lab were related to CSS and not Angular.