lab-steven_lab-22#28
Open
BatemanVO wants to merge 31 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:lab-22
Open
lab-steven_lab-22#28BatemanVO wants to merge 31 commits intocodefellows-seattle-javascript-401d12:masterfrom BatemanVO:lab-22
BatemanVO wants to merge 31 commits intocodefellows-seattle-javascript-401d12:masterfrom
BatemanVO:lab-22
Conversation
Also added babel loader to webpack.config.js.
Cowsay will now reference this.currentCow, which will be set in the HTML file by doing an ng-model on the select box's value as cowsayCtrl.currentCow. The value is initialized on the section tag, which is where the controller is instantiated, using ng-init. The options tag is populated using ng-repeat.
Will now hide the second pre tag if the history array is empty.
When the form is submitted, it will update this.savedCow to be a copy of the current pre's cow and push it to the history state. Since the history state will now have a length greater than 0, it will display on the bottom of the page.
Wrapped second pre and button in a div with the ng-show attribute instead of having it on the pre so that the button won't show if there's nothing to remove. Clicking 'show previous' will show the last cow in the history array.
Added karma, jasmine, and phantomJS to package.json. Added new npm run scripts to package.json to make use of karma. Created karma config file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.