Lab 22 jonny#37
Open
jonathanheemstra wants to merge 35 commits intocodefellows-seattle-javascript-401d12:masterfrom
Open
Lab 22 jonny#37jonathanheemstra wants to merge 35 commits intocodefellows-seattle-javascript-401d12:masterfrom
jonathanheemstra wants to merge 35 commits intocodefellows-seattle-javascript-401d12:masterfrom
Conversation
scaffold files and set up package.json
set up and test webconfig
inital buildout of entry.js
built out and tested cowsay app
Buildout scss
add a readme
refactor entry js
updated package.json
update index.html
add in undo function
refactor webpack config file
added karma.conf file and updated package.json
kaylynyuh
reviewed
Jan 23, 2017
| "jasmine-core": "^2.5.2", | ||
| "karma": "^1.4.0", | ||
| "karma-jasmine": "^1.1.0", | ||
| "karma-mocha-reporter": "^2.2.1", |
There was a problem hiding this comment.
Way to add this to make the tests more readable when you run them in the terminal!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question:
I tried to abstract out some of the test setup into before statements, specifically I attempted to abstract out setting up variables like
let expected = cowsay.say({ text: 'testing', f: this.cowsayCtrl.current });so that I could repeatably call them in various tests but I got errors saying the variable didn't exist even though I used fat arrow functions and I assumed the test would have access to the variable. Does angular mocks provide some kind of scoping that is not readily apparent?Observation:
Using a mocking library like angular mocks library really helps with making testing in angular much easier and abstracts out quite a bit of the overhead in setting up testing.