Support for conditions/indicators#9
Conversation
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
File-level RecordInfo name
# Conflicts: # src/tests/dspf.test.ts
…if conditional is active
|
@janfh As part of this PR, I think you should run |
| getConditions(): Condition[] { | ||
| return this.conditions; | ||
| } |
There was a problem hiding this comment.
I am not sure I understand this API very well. It returns the following interface as an array:
interface Condition {
indicators: Indicator[];
}but I don't quite understand it, and it could be me. Is this because each condition line can have 3 indicators, and each line is actually a unique condition (because you can use and or or when testing each condition right?)
Perhaps condition also needs an additional property to handle when O is specified?
interface Condition {
indicators: Indicator[];
operator?: `and`|`or`; //and is default?
}There was a problem hiding this comment.
For example, here is some DDS for a constant:
A 01 02N03 8 3'One, Two, not Three'
A 01
AA 02
Does this read as three conditions:
- The first with three indicators, the last negated
- The second with one indicator
- The last with one indicator, and with the
A(and) condition?
|
WHOOPS i didn't meant to close this, but we made the new editor the base branch! so can you re-open this against |
Implemented support for conditions/indicators. New class
Conditionalwith support for 9 conditions (OR-groups), each with max 9 indicators (grouping by AND) as described in the DDS reference manual.isActiveevaluates if conditions are met by given indicator status (DisplayFileIndicators).