Skip to content

Fixed IASP support#3258

Open
sebjulliand wants to merge 6 commits into
masterfrom
fixASPListing
Open

Fixed IASP support#3258
sebjulliand wants to merge 6 commits into
masterfrom
fixASPListing

Conversation

@sebjulliand
Copy link
Copy Markdown
Member

Changes

Fixes #3242

This PR fixes potential issues found when using IASP.

  • It removes the queries to ASP_INFO SQl service as it requires special authorities in 7.6+.
  • It adds support for defining an IASP at the Profile level.
    image

Using a profile, user can easily switch between iasps.

  • The iasp cannot be set on the default profile, it will always be assumed that the default asp will be set on the job description used by the user.

  • The library list validation method has been changed to use SQL instead of librarylist.

The ASP unit tests have been updated to support these changes. It is now required to set the iASP used for testing in the .env file:
image

If it's not set, the tests are skipped.

Tests work fine:
image

How to test this PR

  1. Find an IBM i with one or IASPs
  2. Create a profile to use an iasp
  3. Add a filter to browse a library on iasp
  4. Create a source file
  5. Create a member
  6. It must be possible to open it and compile in a library set in an iasp
  7. The library list must work with libraries locate on the current iasp

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand requested a review from a team June 4, 2026 17:39
@sebjulliand sebjulliand self-assigned this Jun 4, 2026
@sebjulliand sebjulliand added bug A confirmed issue when something isn't working as intended enhancement New feature or request labels Jun 4, 2026
@sebjulliand sebjulliand temporarily deployed to testing_environment June 4, 2026 17:39 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

👋 A new build is available for this PR based on 6391717.

Comment thread src/api/IBMi.ts
if (asp !== this.currentASP) {
await Promise.all([
this.runSQL('connect reset').then(() => asp ? this.runSQL(`connect to ${asp}`) : undefined),
this.sendCommand({ command: 'cl "SETASPGRP *NONE"' }).then(() => asp ? this.sendCommand({ command: `cl "SETASPGRP ${asp}"` }) : undefined)
Copy link
Copy Markdown
Member

@buzzia2001 buzzia2001 Jun 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command not qualified

this.sendCommand({ command: 'cl "QSYS/SETASPGRP *NONE"' }).then(() => asp ? this.sendCommand({ command: cl "QSYS/SETASPGRP ${asp}" }) : undefined)

Copy link
Copy Markdown
Member

@buzzia2001 buzzia2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @sebjulliand
it seems to work, there is 1 command to qualify...
Also test cases related to iasp are ok

@sebjulliand
Copy link
Copy Markdown
Member Author

Thanks @buzzia2001 , I'll fix that soon.
I wonder if I should add a way to specify an iASP dev name in case it differs from the database it's linked too (it's uncommon, but possible).

Something like dbName/iaspDevName maybe?

@buzzia2001
Copy link
Copy Markdown
Member

Thanks @buzzia2001 , I'll fix that soon.

I wonder if I should add a way to specify an iASP dev name in case it differs from the database it's linked too (it's uncommon, but possible).

Something like dbName/iaspDevName maybe?

So I'll try editing whataniasp and see what happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can no longer open source members after update 3.0.7

2 participants