Skip to content

Fix/search ifs tool 509#3259

Open
rapra41 wants to merge 3 commits into
codefori:masterfrom
rapra41:fix/searchIFSTool_509
Open

Fix/search ifs tool 509#3259
rapra41 wants to merge 3 commits into
codefori:masterfrom
rapra41:fix/searchIFSTool_509

Conversation

@rapra41
Copy link
Copy Markdown
Contributor

@rapra41 rapra41 commented Jun 5, 2026

Changes

Updated IFS search result handling so permission-denied errors are surfaced in the search view summary instead of separate warnings. Search results now count permission-denied entries from stderr via the warnings array and display them in the message, for example: 179 file(s) contain(s) 'hello' — Permission denied to 5 file(s) and 179 file(s) name 'test1.pf' — Permission denied to 5 file(s). This also keeps the search result flow focused on actual command output instead of relying on exit status alone, since for find/grep searches the presence of useful stdout/stderr data matters more than whether the command exits with zero or non-zero status. A non-zero code can still return valid matches or permission-denied entries, so checking the output is sufficient and more reliable than checking findRes.code.

How to test this PR

  1. Connect to an IBM i system with at least one IFS directory or file that the current user cannot access.
  2. Run an IFS content search and confirm the search view shows the hit count plus — Permission denied to X file(s).
  3. Run an IFS filename search and confirm the search view shows the filename match count plus — Permission denied to X file(s).
  4. Verify no separate popup warning appears for permission-denied results.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md
image image

@rapra41 rapra41 temporarily deployed to testing_environment June 5, 2026 09:02 — with GitHub Actions Inactive
@rapra41 rapra41 deployed to testing_environment June 5, 2026 10:50 — with GitHub Actions Active
@rapra41 rapra41 marked this pull request as ready for review June 5, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant