Fix/search ifs tool 509#3259
Open
rapra41 wants to merge 3 commits into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated IFS search result handling so permission-denied errors are surfaced in the search view summary instead of separate warnings. Search results now count permission-denied entries from stderr via the
warningsarray and display them in the message, for example:179 file(s) contain(s) 'hello' — Permission denied to 5 file(s)and179 file(s) name 'test1.pf' — Permission denied to 5 file(s). This also keeps the search result flow focused on actual command output instead of relying on exit status alone, since forfind/grepsearches the presence of usefulstdout/stderrdata matters more than whether the command exits with zero or non-zero status. A non-zero code can still return valid matches or permission-denied entries, so checking the output is sufficient and more reliable than checkingfindRes.code.How to test this PR
— Permission denied to X file(s).— Permission denied to X file(s).Checklist
console.logs I added