최건위 sprint8#186
Open
geoni-98 wants to merge 13 commits into
Hidden character warning
The head ref may contain hidden characters: "\ucd5c\uac74\uc704-sprint8"
Open
Conversation
eedys1234
reviewed
Apr 22, 2026
|
|
||
| on: | ||
| push: | ||
| branches: [ "release", "최건위-sprint8" ] |
Collaborator
There was a problem hiding this comment.
테스트 하시느라 테스트 하신 브랜치가 같이 있는것 같아요.
| - name: Configure AWS credentials for ECR | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} |
Collaborator
There was a problem hiding this comment.
보안적인 관점에서 Access Key 방식보다는 Role 방식을 권장드립니다.
Access Key는 고정되어 있기 때문에 한번 노출이 되면 문제가 발생할 수 있습니다.
eedys1234
reviewed
Apr 22, 2026
| @@ -0,0 +1,23 @@ | |||
| FROM amazoncorretto:17-alpine AS builder | |||
Collaborator
There was a problem hiding this comment.
멀티스테이지로 진행한다면 도커 이미지가 경량화 되는 장점이 있습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게