[김은진] Sprint 1, 2#22
Open
Eznnni wants to merge 8 commits intocodeit-sprint-fullstack:basic-김은진from
Hidden character warning
The head ref may contain hidden characters: "basic-\uae40\uc740\uc9c4-sprint2"
Open
Conversation
login.html과 signup.html을 구현했다. login-signup.css에 공통으로 스타일을 정의했다. root.css에 앞으로 사용할 color값들을 css변수로 등록하고,"Pretendard" 웹 폰트 정의도 옮겨두었다.
index.html을 제외한 login, signup, items, privacy, faq 파일을 pages 폴더로 이동했다. 그에따른 상대경로도 변경했다. index.html에 root.css를 연결하고, style.css에 있던 웹 폰트 정의를 제거했다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
미션 1️⃣
/login,/items,/privacy,/faq)미션 2️⃣
/signup,/login)심화
미션 1️⃣
rem을 사용하여 사용자의 브라우저 설정에 따라 기본 폰트 크기 설정이 변화함에 따라서 페이지의 요소 간 간격, 요소의 크기, font-size 등 모든 크기와 관련된 값이 크고 작아지도록 설정합니다.미션 2️⃣
주요 변경사항
root.css파일에 전역 컬러 팔레트를 정의했으며, 웹 폰트 또한 동일한 위치에 저장되어 있습니다.index.html을 제외한 요소들이 각각src/assets/icons,src/assets/img,src/pages,src/styles에 저장되어있습니다.스크린샷
멘토에게