Open
Conversation
…' message when input field is empty\n- Add responsive text sizing to Binary Converter (text-lg md:text-xl xl:text-2xl)\n- Add responsive text sizing to book content panel (text-base md:text-lg lg:text-xl xl:text-2xl)\n- Improve readability across all screen sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File:
frontend/src/components/BinaryConverter.tsx
Problem: The "Invalid" error message appeared immediately when the page loaded, before users could even type anything.
Solution: Modified validation logic to only display "Invalid" when there's actual invalid input, not when the field is empty.
{binary === "" ? "" : (dec === undefined || isNaN(dec) ? "Invalid" : dec)}
Impact: Better first impression for students - no confusing error messages on page load.
Files:
frontend/src/components/BinaryConverter.tsx
frontend/src/pages/BookPage.tsx
Problem: Text was too small (12px) on larger screens due to inheriting text-xs from parent containers.
Solution: Added responsive text sizing classes:
Binary Converter: text-lg md:text-xl xl:text-2xl (18px → 24px)
Book Content Panel: text-base md:text-lg lg:text-xl xl:text-2xl (16px → 24px)