Merged
Conversation
- Add global test setup in agents lib for @langchain/openai mock - Fix ContactsService mock in persistent-context middleware spec - Resolve open handles in web api chat route tests by consuming streams - Configure sales lib jest to pass with no tests COAUTHOR="Co-authored-by: Antigravity AI <agent@antigravity.google>
Baba-2001
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on fixing hanging and failing unit tests across the workspace, along with improving the Jest configuration for better stability and centralized mock setups.
🛠️ Changes Made
@langchain/openaiand provide a functional MockChatOpenAI implementation.setupFilesAfterEnv.tsconfig.lib.jsonandtsconfig.spec.jsonfor proper compilation.persistent-context.middleware.spec.tsin Agents Library (libs/agents/src/lib/middleware/persistent-context.middleware.spec.ts)ContactsServiceto correctly usefindByIdinstead offindOne, ensuring the mock aligns with the actual interface.await response.text()) to prevent tests from hanging on open handles.passWithNoTests: trueto prevent test task failures if no specs are present in the sales package.✅ Verification
nx run-many -t test.