You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent hard VM assertions on call-stack overflow and allow translated apps to catch and recover by throwing a StackOverflowError instead of asserting.
Add the StackOverflowError JavaAPI type so the VM can instantiate and throw a standard Java error.
Ensure VM-side behavior is validated by compiling and running a translated app in VM tests instead of only inspecting source text.
Description
Updated initMethodStack in vm/ByteCodeTranslator/src/nativeMethods.m to detect call-stack overflow and call throwException(threadStateData, __NEW_INSTANCE_java_lang_StackOverflowError(threadStateData)) and return instead of asserting.
Added vm/JavaAPI/src/java/lang/StackOverflowError.java implementing java.lang.StackOverflowError as a subclass of java.lang.VirtualMachineError with standard constructors.
Enhanced test runtime stubs in vm/tests/src/test/java/com/codename1/tools/translator/CompilerHelper.java to implement the real exception dispatch flow (fill-in-stack, set threadStateData->exception, unwind try-blocks, longjmp to handlers, and fallback exit(1)) and to provide a compatible instanceofFunction stub to enable exception matching.
Added a VM-focused test vm/tests/src/test/java/com/codename1/tools/translator/StackOverflowHandlingTest.java that (1) compiles and runs a translated app which triggers a stack overflow and asserts the app can catch StackOverflowError and continue, and (2) verifies nativeMethods.m references and throws StackOverflowError and that VirtualMachineError.java exists in the JavaAPI.
Testing
No automated test runs were executed as part of this change; the new VM unit test StackOverflowHandlingTest and modified stubs were added but not run in CI or locally.
The change set was inspected to confirm initMethodStack throws StackOverflowError, that StackOverflowError.java was added to the JavaAPI, and that runtime stubs were updated to support exception dispatch in compiled tests.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.
Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835. Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StackOverflowErrorinstead of asserting.StackOverflowErrorJavaAPI type so the VM can instantiate and throw a standard Java error.Description
initMethodStackinvm/ByteCodeTranslator/src/nativeMethods.mto detect call-stack overflow and callthrowException(threadStateData, __NEW_INSTANCE_java_lang_StackOverflowError(threadStateData))and return instead of asserting.vm/JavaAPI/src/java/lang/StackOverflowError.javaimplementingjava.lang.StackOverflowErroras a subclass ofjava.lang.VirtualMachineErrorwith standard constructors.vm/tests/src/test/java/com/codename1/tools/translator/CompilerHelper.javato implement the real exception dispatch flow (fill-in-stack, setthreadStateData->exception, unwind try-blocks,longjmpto handlers, and fallbackexit(1)) and to provide a compatibleinstanceofFunctionstub to enable exception matching.vm/tests/src/test/java/com/codename1/tools/translator/StackOverflowHandlingTest.javathat (1) compiles and runs a translated app which triggers a stack overflow and asserts the app can catchStackOverflowErrorand continue, and (2) verifiesnativeMethods.mreferences and throwsStackOverflowErrorand thatVirtualMachineError.javaexists in the JavaAPI.Testing
StackOverflowHandlingTestand modified stubs were added but not run in CI or locally.initMethodStackthrowsStackOverflowError, thatStackOverflowError.javawas added to the JavaAPI, and that runtime stubs were updated to support exception dispatch in compiled tests.Codex Task