Fix PMD UnusedPrivateField / UnnecessaryLocalBeforeReturn violations and tighten PMD gates #4451

shai-almog · 2026-01-20T04:40:23Z

Motivation

Address a large set of PMD findings for UnusedPrivateField and UnnecessaryLocalBeforeReturn across core sources to make PMD builds stricter and reduce noise.
Ensure the repository quality report enforces these PMD rules like we already gate on SpotBugs findings.
Exclude UseLocaleWithCaseConversions from PMD since Locale APIs are not available in Codename One.

Description

Removed or inlined numerous unused private fields/constants (examples: removed pollingThreadRunning, various unused gzip constants, R2, _url, pressedX/pressedY, and other dead constants/flags) and cleaned up related code paths in gzip, UI, layout, and util classes.
Replaced trivial local temporaries with direct returns in many methods to eliminate UnnecessaryLocalBeforeReturn (examples: AdsService.createAdsService, ColorUtil.*, Resources.*, RequestBuilder.getAsBytes, ConnectionRequest.fetchJSON, and many UI helper methods).
Added targeted @SuppressWarnings("PMD.UnnecessaryLocalBeforeReturn") where a local is intentionally kept (examples: Inflate.inflate, ThreadSafeDatabase runnables) instead of changing logic.
Updated PMD configuration and CI quality gates by adding <exclude name="UseLocaleWithCaseConversions"/> to maven/core-unittests/pmd.xml and adding UnusedPrivateField and UnnecessaryLocalBeforeReturn to the forbidden PMD rules in .github/scripts/generate-quality-report.py so future PR CI will fail on these violations.

Testing

No automated test suite was executed as part of this change; modifications are focused on refactors and PMD rule conformance.
To validate locally, run the core unit tests and PMD report using the CI-aligned Maven command: cd maven && mvn clean verify -DunitTests=true -pl core-unittests -am -Dmaven.javadoc.skip=true -Plocal-dev-javase.
The quality-report generator was updated to enforce the new PMD gates (see .github/scripts/generate-quality-report.py).

Codex Task

shai-almog · 2026-01-20T05:27:38Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.87% (2665/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.47% (12362/50528), branch 15.35% (717/4672), complexity 17.59% (746/4241), method 33.08% (602/1820), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.87% (2665/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.47% (12362/50528), branch 15.35% (717/4672), complexity 17.59% (746/4241), method 33.08% (602/1820), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

shai-almog · 2026-01-20T05:45:28Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 370 seconds
Compilation Time: 104 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	37138 ms
Extract Extensions	15 ms
Google Services Setup	2 ms
Scan Classes	1147 ms
Extract Libs	958 ms
Inject Build Hints	47 ms
Generate Unit Tests	4 ms
Generate Stubs	1393 ms
Compile Stubs	2442 ms
Generate Icons	1314 ms
Prepare ParparVM	253 ms
ParparVM Execution	201952 ms
Post-VM Setup	162 ms
CocoaPods	5348 ms
Finalize	54 ms
Total Time	252230 msMaven Overhead : 118000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	90000 ms
App Install	21000 ms
App Launch	7000 ms
Test Execution	177000 ms

github-actions · 2026-01-20T05:55:13Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2282 total, 0 failed, 0 skipped
📊 Line coverage: 52.76% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

✅ SpotBugs: 0 findings (no issues) [Report archive]
❌ PMD: 925 findings (P2: 42, P3: 875, P4: 8) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/capture/Capture.java:250 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/compat/java/util/Objects.java:47 – The method name and parameter number are suspiciously close to equals(Object) (rule: SuspiciousEqualsMethodName)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:43 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/components/StorageImageAsync.java:44 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - P2: CodenameOne/src/com/codename1/io/BufferedInputStream.java:38 – Use of modifier volatile is not recommended. (rule: AvoidUsingVolatile)
  - …and 920 more
❌ Checkstyle: 220818 findings (Warning: 220818) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220813 more

Generated automatically by the PR CI workflow.

Fix PMD unused fields and inline returns

f8a3d34

shai-almog added the codex label Jan 20, 2026 — with ChatGPT Codex Connector

Restore button press fields and style alignment constants

3e662a5

Remove unused button state fields and constants

900d80a

shai-almog merged commit d9d422f into master Jan 20, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix PMD UnusedPrivateField / UnnecessaryLocalBeforeReturn violations and tighten PMD gates #4451

Fix PMD UnusedPrivateField / UnnecessaryLocalBeforeReturn violations and tighten PMD gates #4451

shai-almog commented Jan 20, 2026

Uh oh!

shai-almog commented Jan 20, 2026 •

edited

Loading

Uh oh!

shai-almog commented Jan 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix PMD UnusedPrivateField / UnnecessaryLocalBeforeReturn violations and tighten PMD gates #4451

Fix PMD UnusedPrivateField / UnnecessaryLocalBeforeReturn violations and tighten PMD gates #4451

Conversation

shai-almog commented Jan 20, 2026

Motivation

Description

Testing

Uh oh!

shai-almog commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Jan 20, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Jan 20, 2026 •

edited

Loading

shai-almog commented Jan 20, 2026 •

edited

Loading