Skip to content

fix: resolve WASM compilation, signature verification, and contract type errors#1

Open
codenerde wants to merge 2 commits into
mainfrom
new_fixes
Open

fix: resolve WASM compilation, signature verification, and contract type errors#1
codenerde wants to merge 2 commits into
mainfrom
new_fixes

Conversation

@codenerde

@codenerde codenerde commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

This PR resolves a batch of compilation and correctness issues across the workspace:

Fixes

  • Remitwise-common: Replaced Vec::with_capacity / extend_from_slice with soroban_sdk::Bytes for no_std WASM compatibility
  • Remitwise-common: Migrated ed25519_verify from free function to env.crypto().ed25519_verify(...) host function
  • Remitwise-common: Updated test helpers to use ed25519-dalek::SigningKey / Signer (dev-dependency only)
  • Remitwise-common: Invalid signature tests changed from assert_eq!(Err(...)) to #[should_panic] to match Soroban panicking behavior
  • Remitwise-common/Cargo.toml: Removed duplicate [features] section
  • Bill payments: Fixed &env → env type mismatch
  • Bill payments: Fixed next_bill use-after-move
  • Generated Cargo.lock via cargo generate-lockfile (unblocks CI step 1)
  • CI: Added cargo clean recommendation for macOS runner cache staleness

Related Issues

Close Remitwise-Org#716
Close Remitwise-Org#713
Close Remitwise-Org#725
Close Remitwise-Org#768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment