[Don't Pull] MR for review purposes#60
Conversation
…ring when nav bar is clicked
Added image visuals
Added my video walklthrough
src/components/MovieList.jsx
Outdated
| // for sidebar home | ||
| const homePage = () => { | ||
| setSearchQuery(''); | ||
| setViewMode('all'); |
There was a problem hiding this comment.
Lets add a comment as to why we set the view Mode here to 'all'
There was a problem hiding this comment.
Added a more explanatory comment on why
| @@ -127,31 +142,38 @@ const MovieList = () => { | |||
|
|
|||
| // for sidebar home | |||
| const homePage = () => { | |||
There was a problem hiding this comment.
Should we rename this, because its for the side bar on the homepage. This way it better represents what we are setting up for.
There was a problem hiding this comment.
Changed the comment to reflect where the homepage is located for better clarity
src/components/MovieCard.jsx
Outdated
| }} | ||
| > | ||
| <img src= {hasWatched ? '../assets/eye-icon.jpg' : '../assets/close-eye-icon.jpg'} alt=" Watch Status" /> | ||
| {/* <img src = {eyeIcon}/> */} |
There was a problem hiding this comment.
Why are lines 36-38 commented out?
There was a problem hiding this comment.
I couldn't find the commented reference you mentioned here in my coding environment, I'm thinking the changes were already cleaned up.
However, the commented lines was updated to a more workable way of accessing my icon for watch and not watch display as the former wasn't displaying the icon on my webpage
|
In general great job! The code looks good overall. Some general tips:
|
|
Thank you so much for the Feedback! |
2 participants
This MR is for reviewing the project code