Skip to content

🤖 fix: use shared settings header tooltips #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeonidasZhak wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −21
Open

🤖 fix: use shared settings header tooltips #3665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions src/browser/features/Settings/SettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
Lock,
} from "lucide-react";
import { useSettings } from "@/browser/contexts/SettingsContext";
import { TooltipIfPresent } from "@/browser/components/Tooltip/Tooltip";
import { useOnboardingPause } from "@/browser/features/SplashScreens/SplashScreenProvider";
import { useExperimentValue } from "@/browser/hooks/useExperiments";
import { isEditableElement, KEYBINDS, matchesKeybind } from "@/browser/utils/ui/keybinds";
Expand Down Expand Up @@ -227,30 +228,32 @@ export function SettingsPage(props: SettingsPageProps) {
>
<div className="flex min-w-0 items-center gap-2">
{props.leftSidebarCollapsed && (
<Button
variant="ghost"
size="icon"
onClick={props.onToggleLeftSidebarCollapsed}
title="Open sidebar"
aria-label="Open sidebar menu"
className="mobile-menu-btn text-muted hover:text-foreground hidden h-6 w-6 shrink-0"
>
<Menu className="h-4 w-4" />
</Button>
<TooltipIfPresent tooltip="Open sidebar" side="bottom">
<Button
variant="ghost"
size="icon"
onClick={props.onToggleLeftSidebarCollapsed}
aria-label="Open sidebar menu"
className="mobile-menu-btn text-muted hover:text-foreground hidden h-6 w-6 shrink-0"
>
<Menu className="h-4 w-4" />
</Button>
</TooltipIfPresent>
)}
<span className="text-foreground text-sm font-semibold">Settings</span>
</div>
<Button
variant="ghost"
size="sm"
onClick={close}
title="Back"
aria-label="Back to previous page"
className="text-muted hover:text-foreground px-2"
>
<ArrowLeft className="h-3.5 w-3.5" />
Back
</Button>
<TooltipIfPresent tooltip="Back" side="bottom">
<Button
variant="ghost"
size="sm"
onClick={close}
aria-label="Back to previous page"
className="text-muted hover:text-foreground px-2"
>
<ArrowLeft className="h-3.5 w-3.5" />
Back
</Button>
</TooltipIfPresent>
</div>

<div className="flex min-h-0 flex-1 overflow-hidden">
Expand Down