🤖 fix: avoid OpenAI tool search name collision#3719
Merged
Conversation
Rename Mux's deferred tool catalog search and preserve compatibility with completed legacy history. > Mux worked on behalf of Mike. --- _Generated with `mux` • Model: `openai:gpt-5.6-sol` • Thinking: `xhigh` • Cost: `$27.56`_ <!-- mux-attribution: model=openai:gpt-5.6-sol thinking=xhigh costs=27.56 -->
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename Mux's deferred MCP catalog search tool from
tool_searchtotool_catalog_searchso OpenAI Responses treats it as a custom function tool rather than its native tool-search primitive.Background
AI SDK 7 reserves
tool_searchfor OpenAI's native tool search and validates results against{ tools: [...] }. Mux returned{ query, matches, totalDeferred }, so continuing after a catalog search failed with a type-validation error.Implementation
tool_catalog_search.tool_searchcalls in provider-bound messages without changing persisted history.Validation
MUX_ESLINT_CONCURRENCY=1 make static-checkRisks
Low. The live name changes only while the tool-search experiment is enabled. Compatibility handling is request-only and requires the historical result to match Mux's catalog-search shape.
Generated with
mux• Model:openai:gpt-5.6-sol• Thinking:xhigh• Cost:$27.56