Skip to content

feat: add EnableAccountVerifier configuration flag #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfrancisc wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −0
Open

feat: add EnableAccountVerifier configuration flag #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/v1alpha1/docs/apiref.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2139,6 +2139,10 @@ considered enabled. Only listed integrations are hidden. + | | Optional: \{} +

| *`accountVerifierURL`* __string__ | AccountVerifierURL is the URL used to call the account verifier service + | | Optional: \{} +

| *`enableAccountVerifier`* __boolean__ | EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, +
which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's +
response. When set to false or not set, the account-verifier is still called but the response is only logged. + | | Optional: \{} +

|===


Expand Down
6 changes: 6 additions & 0 deletions api/v1alpha1/toolchainconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ type RegistrationServiceConfig struct {
// AccountVerifierURL is the URL used to call the account verifier service
// +optional
AccountVerifierURL *string `json:"accountVerifierURL,omitempty"`

// EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service,
// which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's
// response. When set to false or not set, the account-verifier is still called but the response is only logged.
// +optional
EnableAccountVerifier *bool `json:"enableAccountVerifier,omitempty"`
Comment on lines +265 to +269
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Wire this field through host-operator before relying on it.

EnableAccountVerifier is added to the API, but linked-repo findings show no EnableAccountVerifier/enableAccountVerifier usage in codeready-toolchain/host-operator. Until host-operator consumes and propagates this field to registration-service behavior, this flag is effectively inert and does not meet the PR objective.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@api/v1alpha1/toolchainconfig_types.go` around lines 265 - 269, The new
EnableAccountVerifier (*bool) field on ToolchainConfig is added to the API but
not propagated to host-operator; update host-operator to read
ToolchainConfig.Spec.EnableAccountVerifier (or the ToolchainConfig status path
you use) and propagate it into the registration-service configuration (e.g., add
an env var or ConfigMap key named enableAccountVerifier consumed by
registration-service) by updating the relevant reconciler (controller) that
manages registration-service deployment/template, ensure the JSON field name
enableAccountVerifier is used consistently, add any necessary RBAC and CR watch
for ToolchainConfig in the reconciler, and add/adjust unit/integration tests to
assert the field flows through from ToolchainConfig -> host-operator ->
registration-service.

}

// RegistrationServiceAnalyticsConfig contains the subset of registration service configuration parameters related to analytics
Expand Down
5 changes: 5 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions api/v1alpha1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.