docs: promote MCP support proposal to ADR-0008#116
Conversation
- Distill design doc and questions doc into an architecture decision record
- Consolidate all 7 design questions into a decisions table with rationale
- Remove implementation details (file paths, Go structs, phase checklists)
- Delete docs/proposals/mcp-support-{design,questions}.md
Signed-off-by: Alexey Kazakov <alkazako@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughThis PR consolidates MCP (Model Context Protocol) server support design documentation from two proposal files into ADR-0008. The ADR specifies the ChangesMCP Support Architecture Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/adr/0008-mcp-support.md`:
- Around line 59-92: The fenced flow diagram block that begins with "Claw CR
spec.mcpServers" and ends at "merge.js (init-config at pod start)" is missing a
Markdown language tag; update the opening fence (the triple backticks before
that diagram) to include a language identifier such as text (e.g., change ``` to
```text) so the block passes MD040 linting and remains otherwise unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: acd48a74-ca7b-463e-bdc1-3ef3bac9282e
📒 Files selected for processing (3)
docs/adr/0008-mcp-support.mddocs/proposals/mcp-support-design.mddocs/proposals/mcp-support-questions.md
💤 Files with no reviewable changes (2)
- docs/proposals/mcp-support-questions.md
- docs/proposals/mcp-support-design.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
docs/adr/0008-mcp-support.md
🪛 LanguageTool
docs/adr/0008-mcp-support.md
[grammar] ~14-~14: Ensure spelling is correct
Context: ...servers are recommended over stdio. For stdio, a proxy-placeholder pattern keeps secr...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~46-~46: Ensure spelling is correct
Context: ...o secrets on the gateway. Tier 2 — Stdio MCP subprocesses inherit HTTP_PROXY/`...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.22.1)
docs/adr/0008-mcp-support.md
[warning] 59-59: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (1)
docs/adr/0008-mcp-support.md (1)
24-217: Solid ADR consolidation and decision traceabilityThe decisions table, tiered security model, reconciliation flow, validation split (CEL vs reconciler), and end-to-end CR example read consistently and make this ADR actionable for implementation and operations.
Summary by CodeRabbit