docs: promote web search proposal to ADR-0009#119
Conversation
- Distill design + questions docs into architecture decision record - Consolidate 9 design decisions into rationale table - Remove implementation details, keep architectural contracts - Delete source proposal files from docs/proposals/ Signed-off-by: Alexey Kazakov <alkazako@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughThis PR updates the web-search ADR status from "Final" to "Implemented" and consolidates decision rationale with detailed explanations of API key delivery, provider configuration, proxy injection, and CRD schema handling. A separate proposal-questions document is removed as decisions are now integrated into the ADR. ChangesADR Consolidation and Status Update
Proposal Document Cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/adr/0009-web-search.md`:
- Line 202: Change the lowercase provider name to the proper noun "Google" in
the documentation text: replace references to models.providers.google.apiKey and
plugins.entries.google.config.webSearch where they are described in prose (e.g.,
"google LLM provider") so the phrase reads "Google LLM provider" while leaving
the actual config keys (models.providers.google.apiKey and
plugins.entries.google.config.webSearch) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 9d9991f4-3494-40ad-be4e-8a27695c210f
📒 Files selected for processing (2)
docs/adr/0009-web-search.mddocs/proposals/web-search-questions.md
💤 Files with no reviewable changes (1)
- docs/proposals/web-search-questions.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
docs/adr/0009-web-search.md
🪛 LanguageTool
docs/adr/0009-web-search.md
[uncategorized] ~202-~202: “Google” is a proper noun and needs to be capitalized.
Context: ...ders.google.apiKey` already set for the google LLM provider. User-provided config for ...
(A_GOOGLE)
Summary by CodeRabbit